Skip to content

fix #1732#1733

Merged
aashish24 merged 2 commits intomasterfrom
issue_1732_fillarea_no_transparency
Dec 14, 2015
Merged

fix #1732#1733
aashish24 merged 2 commits intomasterfrom
issue_1732_fillarea_no_transparency

Conversation

@doutriaux1
Copy link
Copy Markdown
Contributor

No description provided.

@doutriaux1
Copy link
Copy Markdown
Contributor Author

@sankhesh @aashish24 if that doesn't break the test suite it should be a quick review

@doutriaux1
Copy link
Copy Markdown
Contributor Author

goes with CDAT/uvcdat-testdata#93

@doutriaux1
Copy link
Copy Markdown
Contributor Author

OK I uploaded the wrong pix... Back soon

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was 100 it would not respect the color's own opacity. so if you set to (100,0,0,50) you wolud have a filled red square instead of half transparent square.

@aashish24
Copy link
Copy Markdown
Contributor

@doutriaux1 changes looks good to me.. thanks for the explanation..

@aashish24 aashish24 merged commit 5e022b7 into master Dec 14, 2015
@aashish24 aashish24 deleted the issue_1732_fillarea_no_transparency branch December 14, 2015 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants