Conversation
|
@doutriaux1 @aashish24 I am having issues with test_vcs_patterns_hatches.py because this test duplicates one row of data (line 23) which results in duplicate cells when wrapping. Is there a way to test that a variable was instructed to create duplicate data? In that case I should not do wrapping. Thanks! |
|
All these: |
|
@doutriaux1 Yes, that is the test file, the tests are the one I posted. |
|
Baselines that go with this |
danlipsa
force-pushed
the
irregular-cut-wrap
branch
from
357f781 to
1215166
Compare
|
@doutriaux1 @aashish24 I think I found a solution. I wrap only for TransientCurveGrid |
sampleCurveGrid4.nc data is cut along an irregular line (not along a longitude line). This causes lon data to vary betwen -40 and 361. We wrap this data to the -40,320 interval. In general we wrap data to the interval minX,minX+360 where minX is the minimum longitude value.
danlipsa
force-pushed
the
irregular-cut-wrap
branch
from
1215166 to
d58bd1b
Compare
|
@doutriaux1 @aashish24 please review. Note the 36 updated baselines. |
|
@doutriaux1 the macs seem hanged. Could you restart them? Thanks! |
|
@doutriaux1 @aashish24 Ping |
|
@doutriaux1 @aashish24 All test passed, please review. I would like to merge this in. |
|
Looks good to me but it would be great if @doutriaux1 can review this. |
|
@danlipsa @aashish24 @williams13 do we want this in 2.4 or in 2.4.1 ? |
|
@doutriaux1 we definitely want in 2.4.1. We can start 2.4.0 with a older sha if needed. |
|
@doutriaux1 could you please review this branch ? |
There was a problem hiding this comment.
It is a terminology VTK uses. It is just an index to keep track of where pieces of cells end up after I wrap the dataset around. Certain cells will be cut in two pieces which will end up in different parts of the dataset. When the scalars are updated I use those indexes to set the proper scalar for each cell.
danlipsa
force-pushed
the
irregular-cut-wrap
branch
from
c8fdceb to
d58bd1b
Compare
|
Sorry, I pushed by mistake my current work on top of this. All tests should pass now. |
|
@danlipsa looks like master is too far away from your branch (in baseline) do you mind merging master in? |
|
Never mind, it's a bot issue. But got locked out of both bots... Yeah... Will fix tomorrow. Bots seem OK. Will build on my Mac just to be safe (hopefully tonight) and will merge |
|
@doutriaux1 Sounds good. Thanks Charles. |
|
ok passes on my mac as well. Merging! |
3 participants
No description provided.