Merged
Conversation
Contributor
Author
|
goes with CDAT/uvcdat-testdata#107 |
| elif (queries.isline(value) == 1): | ||
| hvalue = value.name | ||
| elif value in vcs.elements["line"]: | ||
| self.linecolor = vcs.elements["line"][value].color[0] |
Contributor
There was a problem hiding this comment.
If vcs.elements["line"][value] returns None, these lines would cause a crash.
If you think that will never happen, please ignore.
Contributor
Author
There was a problem hiding this comment.
yes it should never happen vcs.elements are auto-populated when creating vcs objects
Contributor
|
Apart from the one comment, LGTM. |
Contributor
Author
|
@chaosphere2112 @aashish24 can you please merge. Thanks |
| vals.append(float(V)) | ||
| atts[a] = vals | ||
| f.style = atts.get("fais", f.style) | ||
| if code.find("(") > -1: # ok with have the keywords speeled out |
Contributor
Author
There was a problem hiding this comment.
you don't know about speeling keywords? You should looking into it it's most useful 😉
remove debug comment
typo and magic keyword meaning explained when possible
keywords doc
Contributor
|
LGTM; does it pass all tests? |
Contributor
Author
|
@chaosphere2112 running it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aashish24 @danlipsa @sankhesh 99% fixes for reading VERY old vcs script files, but there are a few tweaks in there for setting
lineattributes using an actual line object or its name, please review.