Fixes doubled colors in legend and reduces label count

[chaosphere2112]

Fixes the issues outlined in #1894; still need to add a test.

[aashish24]

@chaosphere2112 when you add a test could you please reopen this again?

[aashish24]

@chaosphere2112 can you resolve the merge conflicts?

[chaosphere2112]

@aashish24 Yeah; there's another bug that I ran into that I'm running down right now. I'll get an update for this by EOD.

[aashish24]

Sure, thanks.

[chaosphere2112]

@aashish24 I ran into a few more issues, I'll clean this up in the morning.

[chaosphere2112]

@doutriaux1 @aashish24

Here's where this PR stands currently on CDASH.

So this is starting to get a little bit out of hand. I've done some major improvements to some of the baselines (test_vcs_boxfill_zero and test_vcs_boxfill_lev1_lev2 are notably better), but then there's... debatable movement on others (test_vcs_boxfill_lev1_lev2_ext1 is a good example of one that isn't bad, but it's certainly not better than it was). I think I fixed a bug in test_vcs_issue_960 (it looks like the last label was missing from the legend, for some reason). How do people feel about less "pretty" numbers for some scales? I can try and be a little smarter about reverting to the old method (vcs.mkscale), but my first attempt at doing so made test_vcs_boxfill_lev1_lev2 revert back to the old legend.

[aashish24]

@chaosphere2112 less pretty numbers you meant they are decimans now? I like the new legend but I think it would be great to have an option to clamp to round numbers since those are easy to read but in some cases you may not want that.

[chaosphere2112]

@aashish24 The users still have the ability to use round numbers; if they don't specify level_1 and level_2 on the boxfill, it'll behave exactly the same as it always has (which is why I'm not failing more baselines 😉 ). The "less pretty" numbers are a kind of weird artifact of how I'm generating the labels; looking at the code, I'm guessing there's an off-by-one error somewhere that I've missed which is responsible for an extra label making the levels be shifted off of the "nice" values.

[chaosphere2112]

@aashish24 @doutriaux1 Alright, this is ready. I fixed the off-by-one errors, so now the same output should be generated for the same input, plus improvements (like a missing level, and lining up the last level, and other goodies).

[chaosphere2112]

@aashish24 ping

[aashish24]

thanks @chaosphere2112 will look into it today.

[aashish24]

@chaosphere2112 nitpick, do we need this many empty lines?

[chaosphere2112]

Nope, I'll remove the extra one.

[aashish24]

thanks @chaosphere2112

[aashish24]

LGTM 👍

[doutriaux1]

@chaosphere2112 don't forget to delete branch after merging

[chaosphere2112]

@doutriaux1 Sorry, got excited and merged when I was going to bed 😄

[doutriaux1]

you mean you actually take time to sleep! 😜