Fixed inconsistent test names and other related issues#1917
Merged
Fixed inconsistent test names and other related issues#1917
Conversation
Contributor
Author
|
@UV-CDAT/developers its not ready for review yet. I am just posting it here so that you know its coming soon + plus I need to look at the diff carefully (how github is showing it). |
Contributor
Author
|
Also, I may push sorting as different branch since I had to update my branch with latest changes which was little tricky. |
aashish24
force-pushed
the
fix_tests_consistent_names
branch
from
c080bea to
8e2718e
Compare
Contributor
Author
|
data: CDAT/uvcdat-testdata#121 |
aashish24
force-pushed
the
fix_tests_consistent_names
branch
from
a885731 to
500a4a6
Compare
From now on, we will follow this naming convention 1) test_vcs --> test vcs code 2) test_cdms --> test cdms IO code 3) test_genutil --> test utility code
aashish24
force-pushed
the
fix_tests_consistent_names
branch
from
500a4a6 to
309fcb9
Compare
Contributor
Author
I would like this to be merged to master asap so that I can avoid the conflict again if possible. |
Contributor
Author
|
@danlipsa @chaosphere2112 I believe @doutriaux1 is out. Could you two |
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From now on, we will follow this naming convention