Conversation
| elif key is Ellipsis: | ||
| raise CDMSError, "Misuse of ellipsis in specification." | ||
| elif type(key) is types.TupleType: | ||
| elif sinstance(key, tuple): |
There was a problem hiding this comment.
isinstance is misspeled here. Would flake8 catch this?
There was a problem hiding this comment.
yep i need to run flake8 on this.
|
@doutriaux1 Nice cleanup! See my comments. @aashish24 Please review. |
|
@doutriaux1 What about the comments where I said it reverses the order. I don't think that happens actually, but rather it uses the default separator: ' ' rather than \n or , |
|
@danlipsa I commented on this, it doesn't reverse the order, look at my sample code in my comments. In [1]: import string
In [2]: string.join(["A","B"],"-")
Out[2]: 'A-B'
In [3]: "-".join(["A","B"])
Out[3]: 'A-B' |
|
@doutriaux1 I see. Confusing syntax for the join in statement 3! You would expect a member function of an object to be applied to the object, so the result would be - A B. Another possible interpretation is that we use "-" just to select between unicode and ascii so the result in that case is A B with the default separator. I like the syntax in 2 a lot better. |
|
@doutriaux1 LGTM. 👍 |
|
@doutriaux1 looks like we need to update the branch to resolve the conflict. |
3 participants
@danlipsa this is the rest of your PR that you merged before I got a chance to push it. Please review.