Merged
Conversation
Contributor
Author
Contributor
Author
|
Do: test |
Contributor
Author
|
@sankhesh The buildbot does not seem to get activated. Do you know why? |
Contributor
Author
|
Do: check |
Contributor
Author
|
Do: test |
Contributor
Author
|
@chaosphere2112 Please review. The orthographic tests changes seem to be triggered by your fix. Did you run the tests when submitting the PR? I did merge it without asking. 😄 |
Contributor
Author
|
@chaosphere2112 @doutriaux1 @aashish24 Please review. Take a look at cdash - 26 tests failing compared with 31 on master. |
Contributor
Author
|
@doutriaux1 Any chance we get the hd5 fix in master? 😄 Many of the 26 tests failing are caused by the hdf5 fix you already have. I suggest you merge only that or all your travis branch. (initially I posted this to the wrong PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.