Issue 691 interact mac broken

[doutriaux1]

@dlonie @aashish24 please review and feel free to suggest better/cleaner solutions.
@ThomasMaxwell wouldn't mind you looking this over as well and testing it against DV3D.

[ThomasMaxwell]

Did a brief interaction/resize test- don't see any problems for the 3D plots.

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Tuesday, November 18, 2014 6:20 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: [uvcdat] Issue 691 interact mac broken (#905)

@dloniehttps://github.com/dlonie @aashish24https://github.com/aashish24 please review and feel free to suggest better/cleaner solutions.
@ThomasMaxwellhttps://github.com/ThomasMaxwell wouldn't mind you looking this over as well and testing it against DV3D.

---

You can merge this Pull Request by running

git pull https://github.com/UV-CDAT/uvcdat issue_691_interact_mac_broken

Or view, comment on, or merge it at:

#905

Commit Summary

• put changes back in
• merge master in this
• added AnyEvent to see what is happening (not much on mac)
• ok this works, needs clean up
• ok not quite there... no left click segfaults
• ok works on Mac
• Merge branch 'master' into issue_691_interact_mac_broken
• rendering the clickrenderer seg fault on mac if clicked before and resize, commenting out fixes it
• works on Linux now

File Changes

• M Packages/vcs/Lib/VTKPlots.pyhttps://github.com/Issue 691 interact mac broken #905/files#diff-0 (47)

Patch Links:

• https://github.com/UV-CDAT/uvcdat/pull/905.patch
• https://github.com/UV-CDAT/uvcdat/pull/905.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/905.

[alliepiper]

Just as a general style note, committed commented out code is rarely necessary. If you've removed something, the old implementation is still stored in git, and if it's new code, why add it if it isn't used? Otherwise it just clutters the codebase and gets in the way of readability.

If there is a reason to leave a commented code path in, a comment explaining why is a good idea.

[doutriaux1]

nope. It's just that i'm lazy and didn't want to go through git to uncoment it in case we need further development on this issue 😉

[doutriaux1]

@dlonie please make sure I got them all now.

[alliepiper]

Almost -- check the new diff.

[alliepiper]

Looks good to me! Thanks for fixing those up.

There were some conflicts when I went to merge master in. Can you address those before we merge?

[alliepiper]

Wait a sec, I think I had an older version checked out....

[doutriaux1]

github says it canmerge w/o conflict