Skip to content

Vcs3 d fix z axis problems#907

Merged
doutriaux1 merged 7 commits intomasterfrom
vcs3D-fix_z_axis_problems
Nov 20, 2014
Merged

Vcs3 d fix z axis problems#907
doutriaux1 merged 7 commits intomasterfrom
vcs3D-fix_z_axis_problems

Conversation

@ThomasMaxwell
Copy link
Copy Markdown
Contributor

Jerry found a bug created by the name change from 'xyt' to 'Hovmoller3D' This branch fixes that error and should go into version 2.1. It also adds a Hovmoller test that catches this issue.

@ThomasMaxwell ThomasMaxwell added this to the 2.1 milestone Nov 19, 2014
@ThomasMaxwell ThomasMaxwell self-assigned this Nov 19, 2014
commenting out print statement
@doutriaux1
Copy link
Copy Markdown
Contributor

ok @ThomasMaxwell looks good to me will run locally as we might run again into the picture not passing on ubuntu issue. If so will update the pix and approve.

@ThomasMaxwell
Copy link
Copy Markdown
Contributor Author

Thanks!

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, November 19, 2014 2:37 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Vcs3 d fix z axis problems (#907)

ok @ThomasMaxwellhttps://github.com/ThomasMaxwell looks good to me will run locally as we might run again into the picture not passing on ubuntu issue. If so will update the pix and approve.


Reply to this email directly or view it on GitHubhttps://github.com//pull/907#issuecomment-63699600.

doutriaux1 added a commit that referenced this pull request Nov 20, 2014
Vcs3 d fix z axis problems

ok tests pass on my ubuntu no need to update any files. Merging
@doutriaux1 doutriaux1 merged commit 78ddb17 into master Nov 20, 2014
@doutriaux1 doutriaux1 deleted the vcs3D-fix_z_axis_problems branch November 20, 2014 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants