Skip to content

Fix error causing 3D plots to hang#940

Merged
aashish24 merged 1 commit intomasterfrom
vcs3D-fix_3d_plot_hanging
Dec 4, 2014
Merged

Fix error causing 3D plots to hang#940
aashish24 merged 1 commit intomasterfrom
vcs3D-fix_3d_plot_hanging

Conversation

@ThomasMaxwell
Copy link
Copy Markdown
Contributor

No description provided.

@aashish24
Copy link
Copy Markdown
Contributor

Almost looks good but will test and build just to make sure.

@aashish24
Copy link
Copy Markdown
Contributor

@williams13 please wait for testing until I test this one.

@williams13
Copy link
Copy Markdown
Contributor

Will do!

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, December 4, 2014 7:45 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Fix error causing 3D plots to hang (#940)

@williams13https://github.com/williams13 please wait for testing until I test this one.


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-65651299.

@aashish24
Copy link
Copy Markdown
Contributor

@ThomasMaxwell found one issue with this branch. Basically vcs_close test is now failing if I merge this one. I can see why. Can you look into it please?

@ThomasMaxwell
Copy link
Copy Markdown
Contributor Author

I find that, with my branch merged, the 'vcs_test_close' ctest fails the first time it runs and then passes if you run it a second (or more) time(s). I did not implement this test and I don't know what it's doing, but its inconsistency suggests that there is something wrong with it. I would advise merging the branch so Dean and Jerry can continue their testing. Whoever wrote that ctest should take a look at it to see what's causing the problems.

-- Tom

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, December 4, 2014 12:23 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Fix error causing 3D plots to hang (#940)

@ThomasMaxwellhttps://github.com/ThomasMaxwell found one issue with this branch. Basically vcs_close test is now failing if I merge this one. I can see why. Can you look into it please?


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-65668254.

@aashish24
Copy link
Copy Markdown
Contributor

Okay, that sounds reasonable to me. I can look at the test. The code you had most looked good to me.

aashish24 added a commit that referenced this pull request Dec 4, 2014
@aashish24 aashish24 merged commit d21b3b7 into master Dec 4, 2014
@aashish24 aashish24 deleted the vcs3D-fix_3d_plot_hanging branch December 4, 2014 21:52
@aashish24
Copy link
Copy Markdown
Contributor

@williams13 please test the current master.

@williams13
Copy link
Copy Markdown
Contributor

Okay, I will give it a try now.

-Dean

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, December 4, 2014 1:52 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Fix error causing 3D plots to hang (#940)

@williams13https://github.com/williams13 please test the current master.


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-65710323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants