Conversation
|
Almost looks good but will test and build just to make sure. |
|
@williams13 please wait for testing until I test this one. |
|
Will do! From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com> @williams13https://github.com/williams13 please wait for testing until I test this one. — |
|
@ThomasMaxwell found one issue with this branch. Basically vcs_close test is now failing if I merge this one. I can see why. Can you look into it please? |
|
I find that, with my branch merged, the 'vcs_test_close' ctest fails the first time it runs and then passes if you run it a second (or more) time(s). I did not implement this test and I don't know what it's doing, but its inconsistency suggests that there is something wrong with it. I would advise merging the branch so Dean and Jerry can continue their testing. Whoever wrote that ctest should take a look at it to see what's causing the problems. -- Tom From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com> @ThomasMaxwellhttps://github.com/ThomasMaxwell found one issue with this branch. Basically vcs_close test is now failing if I merge this one. I can see why. Can you look into it please? — |
|
Okay, that sounds reasonable to me. I can look at the test. The code you had most looked good to me. |
Fix error causing 3D plots to hang
|
@williams13 please test the current master. |
|
Okay, I will give it a try now. -Dean From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com> @williams13https://github.com/williams13 please test the current master. — |
No description provided.