Skip to content

Commit f018a04

Browse files
committed
revert enabling drep delegations until NodeToClientV_23 lands in cardano-node.
1 parent 3761f6a commit f018a04

2 files changed

Lines changed: 16 additions & 18 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,18 @@ math: true
1111

1212
#### Added
1313

14-
- `queryLedgerState/delegateRepresentatives` now returns the list of delegators also for the pre-defined always-abstain and always-no-confidence dreps.
14+
- ~~`queryLedgerState/delegateRepresentatives` now returns the list of delegators also for the pre-defined always-abstain and always-no-confidence dreps.~~
15+
16+
> [!NOTE]
17+
> Couldn't get the query available in the cardano-node on-time, so this is still not available in this release, but should be ready for the next as soon as a version of cardano-node with support for the `GetDRepsDelegations` ledger state query is released.
1518
1619
#### Changed
1720

1821
- Bump dependencies to `cardano-node==10.5.1`.
1922

2023
- `queryLedgerState/stakePools` will also include the stake of pools that have just retired. This is useful to consider the voting power granted to such pool for the upcoming epoch ratification.
2124

22-
- Ogmios will now attempt to negotiate older versions of the client protocols, so that it can work with tools and libraries that are lagging behind. However, this means that when using an version that is too old, some state-queries may not work and result in an error. Ogmios will go as low as node-to-client version 17. The details of which queries are NOT available given versions is summarized in the table below:
23-
24-
| version | query not available |
25-
| --- | --- |
26-
| 17 | `queryLedgerState/delegateRepresentatives` |
27-
| 18 | `queryLedgerState/delegateRepresentatives` |
28-
| 19 | `queryLedgerState/delegateRepresentatives` |
29-
| 20 | `queryLedgerState/delegateRepresentatives` |
30-
| 21 | ø |
25+
- Ogmios will now attempt to negotiate older versions of the client protocols, so that it can work with tools and libraries that are lagging behind. Ogmios will go as low as node-to-client version 17. Beyond that, some queries will no longer work and the overall user experience would be degraded.
3126

3227
#### Removed
3328

server/src/Ogmios/Data/Json/Query.hs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -949,23 +949,26 @@ parseQueryLedgerDelegateRepresentatives genResult =
949949
SomeShelleyEra ShelleyBasedEraBabbage ->
950950
Nothing
951951
SomeShelleyEra ShelleyBasedEraConway ->
952-
Just $ SomeCompound2Query
952+
Just $ SomeCompoundQuery
953+
-- Re-enable as soon as NodeToClientV_23 becomes available
954+
-- in a released cardano-node.
955+
--
956+
-- (LSQ.BlockQuery
957+
-- (QueryIfCurrentConway
958+
-- (GetDRepDelegations dreps)
959+
-- )
960+
-- )
953961
(LSQ.BlockQuery
954-
(QueryIfCurrentConway
955-
(GetDRepDelegations dreps)
956-
)
957-
)
958-
(\_ -> LSQ.BlockQuery
959962
(QueryIfCurrentConway
960963
(GetDRepState credentials)
961964
)
962965
)
963-
(\_ _ -> LSQ.BlockQuery
966+
(\_ -> LSQ.BlockQuery
964967
(QueryIfCurrentConway
965968
(GetDRepStakeDistr dreps)
966969
)
967970
)
968-
(\delegs st distr -> mergeAll delegs (Map.mapKeys Ledger.credToDRep st) distr)
971+
(\st distr -> let delegs = Map.empty in mergeAll delegs (Map.mapKeys Ledger.credToDRep st) distr)
969972
(eraMismatchOrResult (encodeMapAsList encodeDRepSummary . withDefaultProtocolDreps))
970973
genResult
971974
where

0 commit comments

Comments
 (0)