Skip to content

Commit 0d4bd1d

Browse files
[ENG-10943] Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response (#11719)
* Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response * Add assertions for 'id' and 'event_name' in subscription detail response test
1 parent b985424 commit 0d4bd1d

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

api/subscriptions/views.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,9 @@ def update(self, request, *args, **kwargs):
306306
raise PermissionDenied
307307

308308
for instance in qs:
309+
instance.legacy_id = self.kwargs['subscription_id']
310+
instance.event_name = instance.notification_type.name
311+
309312
serializer = self.get_serializer(instance=instance, data=request.data, partial=True)
310313
serializer.is_valid(raise_exception=True)
311314
self.perform_update(serializer)
@@ -326,6 +329,9 @@ def update(self, request, *args, **kwargs):
326329
raise PermissionDenied
327330

328331
for instance in qs:
332+
instance.legacy_id = self.kwargs['subscription_id']
333+
instance.event_name = instance.notification_type.name
334+
329335
serializer = self.get_serializer(instance=instance, data=request.data, partial=True)
330336
serializer.is_valid(raise_exception=True)
331337
self.perform_update(serializer)
@@ -354,13 +360,17 @@ def update(self, request, *args, **kwargs):
354360
raise PermissionDenied
355361

356362
for instance in qs:
363+
instance.legacy_id = self.kwargs['subscription_id']
364+
instance.event_name = instance.notification_type.name
365+
357366
serializer = self.get_serializer(instance=instance, data=request.data, partial=True)
358367
serializer.is_valid(raise_exception=True)
359368
self.perform_update(serializer)
360369
return Response(serializer.data)
361370

362371
else:
363372
instance.event_name = instance.notification_type.name # Set event_name for serializer to use
373+
instance.legacy_id = instance.notification_type.name # Set legacy_id for serializer to use
364374

365375
partial = kwargs.pop('partial', False)
366376
serializer = self.get_serializer(instance, data=request.data, partial=partial)

api_tests/subscriptions/views/test_subscriptions_detail.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,3 +342,5 @@ def test_subscription_detail_patch(
342342
res = app.patch_json_api(url_user_global_file_updated, payload, auth=user.auth)
343343
assert res.status_code == 200
344344
assert res.json['data']['attributes']['frequency'] == 'none'
345+
assert res.json['data'].get('id') is not None
346+
assert res.json['data']['attributes'].get('event_name') is not None

0 commit comments

Comments
 (0)