Skip to content

Commit 86784a3

Browse files
committed
update tests
1 parent d49a26e commit 86784a3

1 file changed

Lines changed: 18 additions & 7 deletions

File tree

osf_tests/test_middleware.py

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,30 +40,41 @@ def setUp(self):
4040
self.node = ProjectFactory(creator=self.admin)
4141

4242
@mock.patch(MAINTENANCE_MOCK_PATH, return_value=True)
43-
def test_middleware_blocks_post_when_maintenance_mode_on(self, mock_maintenance):
43+
def test_middleware_blocks_post_if_maintenance_mode_on(self, mock_maintenance):
4444
url = f'/v2/nodes/{self.node._id}/'
4545
response = self.app.post_json(url, {}, expect_errors=True)
4646
assert response.status_code == 503
4747
assert response.json['meta']['maintenance_mode'] is True
4848
assert response.json['meta']['status_page'] == 'https://status.cos.io'
4949

5050
@mock.patch(MAINTENANCE_MOCK_PATH, return_value=True)
51-
def test_middleware_blocks_patch_when_maintenance_mode_on(self, mock_maintenance):
51+
def test_middleware_blocks_patch_if_maintenance_mode_on(self, mock_maintenance):
5252
url = f'/v2/nodes/{self.node._id}/'
53-
response = self.app.patch_json(url, {}, expect_errors=True)
53+
original_title = self.node.title
54+
payload = {
55+
'data': {
56+
'id': self.node._id,
57+
'type': 'nodes',
58+
'attributes': {'title': 'Updated Title'}
59+
}
60+
}
61+
response = self.app.patch_json(url, payload, expect_errors=True)
5462
assert response.status_code == 503
5563
assert response.json['meta']['maintenance_mode'] is True
64+
self.node.reload()
65+
assert self.node.title == original_title
5666

5767
@mock.patch(MAINTENANCE_MOCK_PATH, return_value=True)
58-
def test_middleware_blocks_delete_when_maintenance_mode_on(self, mock_maintenance):
68+
def test_middleware_blocks_delete_if_maintenance_mode_on(self, mock_maintenance):
5969
url = f'/v2/nodes/{self.node._id}/'
6070
response = self.app.delete(url, expect_errors=True)
61-
6271
assert response.status_code == 503
6372
assert response.json['meta']['maintenance_mode'] is True
73+
self.node.reload()
74+
assert self.node.is_deleted is False
6475

6576
@mock.patch(MAINTENANCE_MOCK_PATH, return_value=False)
66-
def test_go_to_post_view_when_maintenance_mode_off(self, mock_maintenance):
77+
def test_go_to_post_view_if_maintenance_mode_off(self, mock_maintenance):
6778
url = '/v2/nodes/'
6879
payload = {
6980
'data': {
@@ -75,7 +86,7 @@ def test_go_to_post_view_when_maintenance_mode_off(self, mock_maintenance):
7586
assert response.status_code == 201
7687

7788
@mock.patch(MAINTENANCE_MOCK_PATH, return_value=False)
78-
def test_go_to_post_view_if_maintenance_mode_off(self, mock_maintenance):
89+
def test_go_to_patch_view_if_maintenance_mode_off(self, mock_maintenance):
7990
url = f'/v2/nodes/{self.node._id}/'
8091
payload = {
8192
'data': {

0 commit comments

Comments
 (0)