Skip to content

Commit 959cbc0

Browse files
Refactor SSO availability validation in InstitutionForm to ensure correct settings based on delegation protocol and institution status
1 parent 41da3c2 commit 959cbc0

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

admin/institutions/forms.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@ def clean(self):
2222
if self.cleaned_data['sso_availability'] != SSOAvailability.HIDDEN.value:
2323
self.add_error(None, 'SSO availability must be set to "Hidden" when the institution is deactivated.')
2424

25+
else:
26+
if self.cleaned_data['sso_availability'] not in [
27+
SSOAvailability.PUBLIC.value,
28+
SSOAvailability.HIDDEN.value
29+
]:
30+
self.add_error(None, 'SSO availability must be set to "Public" or "Hidden" when delegation protocol is configured.')
31+
2532

2633
class InstitutionalMetricsAdminRegisterForm(forms.Form):
2734
""" A form that finds an existing OSF User, and grants permissions to that

0 commit comments

Comments
 (0)