fix issue with subscriptions without types

Author: Johnetordoff

osf/admin.py

@@ -325,13 +325,17 @@ class Media:
         js = ['admin/notification_subscription.js']
 
     def preview_button(self, obj):
-        url = reverse(
-            'admin:notificationtype_preview',
-            args=[obj.notification_type.id]
-        )
+        if obj.notification_type:
+            url = reverse(
+                'admin:notificationtype_preview',
+                args=[obj.notification_type.id]
+            )
+            return format_html(
+                '<a class="button" target="_blank" href="{}">Preview</a>',
+                url
+            )
         return format_html(
-            '<a class="button" target="_blank" href="{}">Preview</a>',
-            url
+            '<a class="button">Missing Notification Type!</a>',
         )
 
     def get_urls(self):

osf/models/notification_subscription.py

@@ -49,7 +49,8 @@ def clean(self):
             raise ValidationError(f'{self.message_frequency!r} is not allowed for {self.notification_type.name!r}.')
 
     def __str__(self) -> str:
-        return f'<{self.user} via {self.subscribed_object} subscribes to {self.notification_type.name} ({self.message_frequency})>'
+        return (f'<{self.user} via {self.subscribed_object} subscribes to '
+                f'{getattr(self.notification_type, 'name', 'MISSING')} ({self.message_frequency})>')
 
     class Meta:
         verbose_name = 'Notification Subscription'