Skip to content

Commit fae251b

Browse files
Update test to be clearer
1 parent 869e0bf commit fae251b

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

packages/google-closure-compiler/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"google-closure-compiler-windows": "^20250915.0.0"
5454
},
5555
"devDependencies": {
56-
"gulp": "^4.0.2 || ^5.0.1",
56+
"gulp": "^5.0.1",
5757
"gulp-sourcemaps": "^3.0.0",
5858
"jasmine": "5.10.0",
5959
"jasmine-console-reporter": "3.1.0",

packages/google-closure-compiler/test/gulp.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -460,17 +460,18 @@ describe('gulp-google-closure-compiler', function() {
460460
ensureCorrectPlatformUtilized();
461461
});
462462

463-
it('in streaming mode should emit an error', async () => {
464-
// Gulp throws a global uncatchable stream error
465-
// Handle the error so that the test suite does not fail
466-
const globalExceptionListener = (err) => {};
467-
process.on('uncaughtException', globalExceptionListener);
463+
it('in streaming mode should emit an error', () => {
468464
let errorEncountered = false;
469-
await new Promise((resolve) => {
465+
return new Promise((resolve, reject) => {
470466
gulp.src(`${__dirname}fixtures/**/*.js`, {buffer: false})
471467
.on('error', (err) =>{
472468
errorEncountered = true;
473469
expect(err.message).toMatch(/^(gulp-google-closure-compiler: )?Streaming not supported/);
470+
})
471+
.on('close', () => {
472+
if (!errorEncountered) {
473+
reject(new Error('should have encountered an error'))
474+
}
474475
resolve();
475476
})
476477
.pipe(closureCompiler({

yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,7 +1124,7 @@ __metadata:
11241124
google-closure-compiler-linux-arm64: "npm:^20250915.0.0"
11251125
google-closure-compiler-macos: "npm:^20250915.0.0"
11261126
google-closure-compiler-windows: "npm:^20250915.0.0"
1127-
gulp: "npm:^4.0.2 || ^5.0.1"
1127+
gulp: "npm:^5.0.1"
11281128
gulp-sourcemaps: "npm:^3.0.0"
11291129
jasmine: "npm:5.10.0"
11301130
jasmine-console-reporter: "npm:3.1.0"
@@ -1203,7 +1203,7 @@ __metadata:
12031203
languageName: node
12041204
linkType: hard
12051205

1206-
"gulp@npm:^4.0.2 || ^5.0.1":
1206+
"gulp@npm:^5.0.1":
12071207
version: 5.0.1
12081208
resolution: "gulp@npm:5.0.1"
12091209
dependencies:

0 commit comments

Comments
 (0)