Merge pull request #129 from achingbrain/fix/write-handshake-nonce-correctly

wemeetagain · web-flow · commit ef649571aed7 · 2022-01-14T08:35:26.000-06:00
fix: write handshake nonce correctly
diff --git a/src/handshakes/abstract-handshake.ts b/src/handshakes/abstract-handshake.ts
@@ -60,7 +60,7 @@ export abstract class AbstractHandshake {
   protected nonceToBytes (n: uint64): bytes {
     // Even though we're treating the nonce as 8 bytes, RFC7539 specifies 12 bytes for a nonce.
     const nonce = new Uint8Array(12)
-    new DataView(nonce.buffer, nonce.byteOffset, nonce.byteLength).setUint32(n, 4, true)
+    new DataView(nonce.buffer, nonce.byteOffset, nonce.byteLength).setUint32(4, n, true)
 
     return nonce
   }

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export abstract class AbstractHandshake {`
`60`	`60`	`protected nonceToBytes (n: uint64): bytes {`
`61`	`61`	`// Even though we're treating the nonce as 8 bytes, RFC7539 specifies 12 bytes for a nonce.`
`62`	`62`	`const nonce = new Uint8Array(12)`
`63`		`- new DataView(nonce.buffer, nonce.byteOffset, nonce.byteLength).setUint32(n, 4, true)`
	`63`	`+ new DataView(nonce.buffer, nonce.byteOffset, nonce.byteLength).setUint32(4, n, true)`
`64`	`64`
`65`	`65`	`return nonce`
`66`	`66`	`}`