Commit de5b119
authored
Add notes about MetricExporter naming (#2286)
If the implementors choose to implement pull metric exporters modeled as a metric reader, the only variant for metric exporter interface is push metric exporter. While the pull metric exporter is modeled as a "metric reader", the better naming for the genric "metric exporter" interface may be "push metric exporter".
Just open this PR to see if there are similar naming confusions with other SDK implementors. If so, I'd believe the metric exporter and metric reader section need a re-structure in a follow-up PR since how the pull metric exporter is modeled is important to the naming of the metric exporter interface.
Related:
- open-telemetry/opentelemetry-js#2707
- open-telemetry/opentelemetry-js#2589 (comment)1 parent 4ec8478 commit de5b119
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
876 | 876 | | |
877 | 877 | | |
878 | 878 | | |
879 | | - | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
880 | 882 | | |
881 | 883 | | |
882 | 884 | | |
| |||
0 commit comments