Skip to content

Commit 380e0f9

Browse files
tibornagy0303caolanm
authored andcommitted
a11y: fix dropdown button keyboard navigation in Calc
Add missing entries to the list to make keyboard navigation consistent. Some dropdown buttons were incorrectly focusable via keyboard navigation even though they open the same content as their corresponding button. Signed-off-by: Tibor Nagy <tibor.nagy@collabora.com> Change-Id: I6dfd0597309e363ba1173e7aa2a121f7cfc68572
1 parent c2d6de8 commit 380e0f9

1 file changed

Lines changed: 25 additions & 0 deletions

File tree

browser/src/control/jsdialog/Util.ButtonType.ts

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,11 @@ function getDialogButtons() {
142142

143143
function getDropdownButtons() {
144144
return [
145+
'.uno:AutoSumMenu',
145146
'.uno:BasicShapes',
146147
'.uno:CharSpacing',
147148
'.uno:CompareDocuments',
149+
'.uno:ConditionalFormatMenu',
148150
'.uno:FormatMenu',
149151
'.uno:FormattingMarkMenu',
150152
'.uno:GrafContrast',
@@ -158,36 +160,59 @@ function getDropdownButtons() {
158160
'.uno:Paste',
159161
'.uno:SetBorderStyle',
160162
'.uno:XLineColor',
163+
'DateAndTimeFunctionsMenu',
161164
'downloadas',
162165
'exportas',
166+
'FinancialFunctionsMenu',
163167
'home-search',
164168
'LanguageStatusMenu',
169+
'LogicalFunctionsMenu',
170+
'LookupAndRefFunctionsMenu',
171+
'MathAndTrigFunctionsMenu',
172+
'MenuColumnWidth',
165173
'MenuMargins',
166174
'MenuOrientation',
175+
'MenuPageSizesCalc',
167176
'MenuPageSizesWriter',
177+
'MenuPrintRanges',
178+
'MenuRowHeight',
179+
'Menu Statistic',
180+
'MoreFunctionsMenu',
168181
'saveas',
169182
'StateTableCellMenu',
183+
'TextFunctionsMenu',
170184
'viewModeDropdownButton',
171185
'zoom',
172186
];
173187
}
174188

175189
function getOverflowGroupDropdownButtons() {
176190
return [
191+
'.uno:AutoSumMenu',
192+
'.uno:ConditionalFormatMenu',
193+
'.uno:DataDataPilotRun',
194+
'.uno:DataFilterAutoFilter',
195+
'.uno:DefineDBName',
177196
'.uno:DrawText',
178197
'.uno:EntireCell',
179198
'.uno:FontDialog',
180199
'.uno:FormatBulletsMenu',
181200
'.uno:FormatGroup',
201+
'.uno:FreezePanes',
202+
'.uno:FullScreen',
182203
'.uno:GrafLuminance',
204+
'.uno:Group',
183205
'.uno:InsertAnnotation',
206+
'.uno:InsertCalcTable',
184207
'.uno:InsertFieldCtrl',
185208
'.uno:InsertFootnote',
186209
'.uno:InsertGraphic',
187210
'.uno:InsertMultiIndex',
211+
'.uno:InsertObjectChart',
188212
'.uno:InsertPagebreak',
189213
'.uno:InsertTable',
190214
'.uno:Paste',
215+
'.uno:ToggleSheetGrid',
191216
'charmapcontrol',
192217
'home-search',
193218
'MenuMargins',

0 commit comments

Comments
 (0)