Skip to content

feat: supsub#217

Merged
Tabaie merged 2 commits intodevelopfrom
string-utils
Jul 3, 2022
Merged

feat: supsub#217
Tabaie merged 2 commits intodevelopfrom
string-utils

Conversation

@Tabaie
Copy link
Copy Markdown
Contributor

@Tabaie Tabaie commented Jun 30, 2022

Integrate the superscript and subscript functions into gnark-crypto (superscript is useful for pretty printing of polynomials)

@Tabaie Tabaie requested a review from gbotrel June 30, 2022 23:12
@gbotrel
Copy link
Copy Markdown
Collaborator

gbotrel commented Jul 1, 2022

lgtm, maybe nitpicking; since you added that in utils package, some method will read like utils.Sub(..) which in the context of the rest of the library sounds a bit confusing :)

@Tabaie
Copy link
Copy Markdown
Contributor Author

Tabaie commented Jul 1, 2022

lgtm, maybe nitpicking; since you added that in utils package, some method will read like utils.Sub(..) which in the context of the rest of the library sounds a bit confusing :)

That's a great point. I'll change it to ToSubscript.

@Tabaie Tabaie changed the base branch from master to develop July 3, 2022 19:58
@Tabaie Tabaie merged commit 04aca0c into develop Jul 3, 2022
@Tabaie Tabaie deleted the string-utils branch July 3, 2022 19:59
@gbotrel gbotrel mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants