Field: add SetInt64 and support for uint8 uint16 ... etc in SetInterface#111
Merged
Field: add SetInt64 and support for uint8 uint16 ... etc in SetInterface#111
SetInt64 and support for uint8 uint16 ... etc in SetInterface#111Conversation
Tabaie
approved these changes
Dec 15, 2021
Contributor
Tabaie
left a comment
Tabaie
left a comment
There was a problem hiding this comment.
LGTM, there's just that one redundant import
| "fmt" | ||
| {{if .NoCarry}} mrand "math/rand" {{end}} | ||
| "testing" | ||
| {{if .UseAddChain}} "fmt" {{ end }} |
Contributor
There was a problem hiding this comment.
Guess we can take this out now
Collaborator
Author
There was a problem hiding this comment.
nope it is used in the added tests 👍
Contributor
There was a problem hiding this comment.
I'm referring to line 13, which conditionally imports "fmt"
Collaborator
Author
There was a problem hiding this comment.
Haaa got you my bad :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.