feat: constant time Equal with tests and benchmarks#144
Merged
Conversation
Collaborator
|
lgtm 👍 @yelhousni I did a quick search and I don't think equal is perf critical anywhere in the pairing or msm, is it? Impact of this PR --> for BW6 curves (not for the others) the equal when field elements are different becomes twice slower (we're talking 2ns to 4ns... ) |
Collaborator
|
I think it's fine to replace the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly faster than
Equalson small moduli, up to %50 slower on big onesMay be useful in algorithms advertised as c-time like sswu hash