Conversation
|
Note on naming: (we've discussed it before but I think it is now clearer in the code)
All SSWU maps follow this scheme, along with BN254. The other SvdW's will follow it when we generify. |
There was a problem hiding this comment.
LGTM except for Svdw hash-to-g2 constants for BN254. If I'm not mistaken, the sage script in the standard (find_z_svdw(Fp2, 0, 3/(u+9)) where Fp2.<u>=GF(p^2,modulus=[1,0,1]) and p=0x30644e72e131a029b85045b68181585d97816a916871ca8d3c208c16d87cfd47) outputs Z=1 which is Z.A0=1 and not Z.A1=1. So the constants should be instead:
Z.A0.SetString("1")
c1.A0.SetString("19485874751759354771024239261021720505790618469301721065564631296452457478374")
c1.A1.SetString("266929791119991161246907387137283842545076965332900288569378510910307636690")
c2.A0.SetString("10944121435919637611123202872628637544348155578648911831344518947322613104291")
c3.A0.SetString("2896050631867192331397261833972217924632033787908606332265566319765989907291")
c3.A1.SetString("69234539592135073670822051309638369246835028322499721100120497037563571475")
c4.A0.SetString("10499238450719652342378357227399831140106360636427411350395554762472100376473")
c4.A1.SetString("6940174569119770192419592065569379906172001098655407502803841283667998553941")
I checked these locally and the tests pass except the test vectors of course which should be regenerated accordingly.
@Tabaie can you please double check this?
No description provided.