Unifying Hash To Curve code generation#209
Merged
Conversation
Contributor
Author
|
I haven't added parameters for some of the other curves in there yet. Will do that after another PR simplifying SSWU code generation, removing generation-time parameter computation, after which I can delete all field arithmetic logic. Currently, if we try to develop field config classes for degree 4 extensions, we would have to implement arithmetic in towers as well which I would like to avoid. |
yelhousni
approved these changes
Jun 16, 2022
Collaborator
yelhousni
left a comment
yelhousni
left a comment
There was a problem hiding this comment.
LGMT! we can merge this.
Also the new svdw is 9% faster for BN254 G1 (and 4% for G2).
Contributor
Author
|
Nice! It's probably because of how the precomputed values are loaded. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifying code generation for SvdW and SSWU