Skip to content

Refactor: do not export endomorphisms + Double in affine#382

Merged
yelhousni merged 2 commits intodevelopfrom
refactor/not-export-endo
Apr 18, 2023
Merged

Refactor: do not export endomorphisms + Double in affine#382
yelhousni merged 2 commits intodevelopfrom
refactor/not-export-endo

Conversation

@yelhousni
Copy link
Copy Markdown
Collaborator

we don't need to export endomorphisms as we don't use them in gnark hints anymore. We do subgroup check directly in the circuit.

@yelhousni yelhousni requested a review from ivokub April 17, 2023 18:03
Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yelhousni yelhousni merged commit 330c1cb into develop Apr 18, 2023
@yelhousni yelhousni deleted the refactor/not-export-endo branch July 5, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants