Small optimization over the memory usage of MiMC#435
Merged
ivokub merged 1 commit intoConsensys:developfrom Jul 24, 2023
Merged
Small optimization over the memory usage of MiMC#435ivokub merged 1 commit intoConsensys:developfrom
ivokub merged 1 commit intoConsensys:developfrom
Conversation
ivokub
approved these changes
Jul 24, 2023
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
Looks good. I'm still a bit puzzled that Go didn't optimize the tmp var allocation inside loop.
I tried a very minimal generic version wihout asm methods of encrypt method in godbolt, but it didn't show any difference in the compiled code. But I didn't use the assembly -optimized squaring, so maybe Go cannot optimize then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resetkeeps the same buffertmpis allocated once above the loop (turns out that the allocation is not optimized)