Merged
Conversation
Summary✅ Passed: 5571 🚧 Skipped
|
ivokub
reviewed
Sep 15, 2023
ivokub
reviewed
Sep 15, 2023
ivokub
reviewed
Sep 15, 2023
ivokub
requested changes
Sep 15, 2023
Summary✅ Passed: 5561 🚧 Skipped
|
Summary✅ Passed: 5607 🚧 Skipped
|
1 similar comment
Summary✅ Passed: 5607 🚧 Skipped
|
Collaborator
|
Rereviewed - we still accept zero signatures. For example, following doesn't fail: func TestZero(t *testing.T) {
var signature Signature
var bts [sizeSignature]byte
_, err := signature.SetBytes(bts[:])
if err == nil {
t.Fatal("expected error")
}
} |
ivokub
reviewed
Sep 19, 2023
ivokub
requested changes
Sep 19, 2023
Summary✅ Passed: 5607 🚧 Skipped
|
As we use compressed coordinates then X is computed from Y.
Summary✅ Passed: 5883 🚧 Skipped
|
ivokub
approved these changes
Sep 27, 2023
Collaborator
There was a problem hiding this comment.
I made some updates - particularly checking against 0 values as this leads to div by zero elsewhere.
Tests work, but would be nice to have a confirmation.
And I checked that negative values are not issues as incoming bytes are represented as unsigned ints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deserialisation eddsa and ecdsa signature now ensures that the data is in [0, mod] where mod is the relevant modulus (field of definition of relevant group size of the curve).
Type of change
Credits to Verichains for raising the issue