Added optional precompute parameter in FFT domain initialization#45
Merged
Added optional precompute parameter in FFT domain initialization#45
Conversation
Collaborator
|
Looks good to me, merging. May revisit with optimization work on Consensys/gnark/issues/69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #36 a performance loss of the FFT which occurred when the support of arbitrary cosets was added.
Description
When creating an FFT domain, a boolean value is now passed as parameter to force some pre computations, namely the BitReverse of the coset table. Forcing the pre computing or not is a time/memory trade off. Forcing the pre computations doubles the memory needed to stored a domain.
API breaking changes
func NewDomain(m, depth uint64, precomputeReversedTable bool) *Domaininstead of:
func NewDomain(m, depth uint64) *DomainBenchmarks
MBP 2.2GHz 6-core i7 - 16GB RAM