Skip to content

fix: fixes #491#492

Merged
ThomasPiellard merged 7 commits intomasterfrom
feat/gen_fr_star
Mar 19, 2024
Merged

fix: fixes #491#492
ThomasPiellard merged 7 commits intomasterfrom
feat/gen_fr_star

Conversation

@ThomasPiellard
Copy link
Copy Markdown
Contributor

Description

Adds a method GenFrStar() in domain.go to get a generator of Fr* (wrongly named "generator of largest two adic subgroup" before").

Fixes # 491

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard requested a review from ivokub March 18, 2024 18:02
Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not sure about the method name, I think it deviates from out current method naming pattern a bit.

@ThomasPiellard ThomasPiellard merged commit 73d5980 into master Mar 19, 2024
@ThomasPiellard ThomasPiellard deleted the feat/gen_fr_star branch March 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants