perf: more elegant solution to mem dump using unsafe and generics#501
Closed
gbotrel wants to merge 4 commits intorefactor/utils_side_effectfrom
Closed
perf: more elegant solution to mem dump using unsafe and generics#501gbotrel wants to merge 4 commits intorefactor/utils_side_effectfrom
gbotrel wants to merge 4 commits intorefactor/utils_side_effectfrom
Conversation
|
📦 |
ivokub
approved these changes
May 3, 2024
Collaborator
ivokub
left a comment
There was a problem hiding this comment.
LGTM. Imo we can add a simple guard in case the slice to write is empty to have better errors, but I think normally shouldn't happen.
| return err | ||
| } | ||
|
|
||
| data := unsafe.Slice((*byte)(unsafe.Pointer(&s[0])), size*len(s)) |
Collaborator
There was a problem hiding this comment.
Add guard in case len(s) == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation; enable other gnark objects (like
groth16.ProvingKey) to be written and read very fast (though not portable). Limit code duplication between curves, fields, proof systems, etc.utils/unsafewithWriteSlice[S ~[]E, E any](w io.Writer, s S) error... ;kzg.UnsafeToBytes(...) []byteis nowWriteDump(w io.Writer) error🔥 Benchmarks for kzg SRS dump 🔥 --> (I mean using
unsafeis a cheat, we just benchmark the non-unsafe method + real IO)