Skip to content

docs: describe length extension attack for MiMC hash function.#520

Merged
gbotrel merged 2 commits intomasterfrom
docs/mimc-lengthextension
Jul 18, 2024
Merged

docs: describe length extension attack for MiMC hash function.#520
gbotrel merged 2 commits intomasterfrom
docs/mimc-lengthextension

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Jul 12, 2024

Description

This PR adds documentation to emphasize the potential issues when using MiMC. Also references issues in gnark-crypto about the format of inputs.

Type of change

  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: cleanup Suggestion to clean up the code type: consolidate strengthen an existing feature labels Jul 12, 2024
@ivokub ivokub requested a review from gbotrel July 12, 2024 12:01
@ivokub ivokub self-assigned this Jul 12, 2024
@gbotrel gbotrel merged commit 7e5f929 into master Jul 18, 2024
@gbotrel gbotrel deleted the docs/mimc-lengthextension branch July 18, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: cleanup Suggestion to clean up the code type: consolidate strengthen an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants