perf: adds AVX512 implementations of vector.Sum, vector.InnerProduct + assembly refactor#547
Merged
perf: adds AVX512 implementations of vector.Sum, vector.InnerProduct + assembly refactor#547
Conversation
* refactor: move common assembly routines in root * build: make linter happier * style: cosmetics * test: start fixing integration test * style: factorize mul documentation * feat: add .ASMVector and fix integartion test * test: fix 32bit test * test: fix previous commit
gbotrel
requested review from
ThomasPiellard,
ivokub and
yelhousni
and removed request for
ThomasPiellard
ivokub
approved these changes
Oct 4, 2024
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
Without trying to understand the assembly definitions, looks good to me. There are a few comments, but rather minor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
vector.Sum,vector.InnerProduct,vector.ScalarMulandvector.Mulpartially derived from Dag Arne Osvik's work in github.com/a16z/vectorized-fieldsBenchmarks
Benchmarks on size from 16 to 16M values.
Seems results are better on AMD EPYC 9R14 (hpc7a, c7a, r7a) than on the intel xeon 8488c (r7i, ...).
hpc7ar7ic7a