Skip to content

chore: fix some function names in comment#559

Merged
ivokub merged 1 commit intoConsensys:fix/typos-v0.15from
cuibuwei:master
Dec 3, 2024
Merged

chore: fix some function names in comment#559
ivokub merged 1 commit intoConsensys:fix/typos-v0.15from
cuibuwei:master

Conversation

@cuibuwei
Copy link
Copy Markdown
Contributor

@cuibuwei cuibuwei commented Dec 2, 2024

Description

fix some function names in comment

Type of change

Please delete options that are not relevant.

  • Docs

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: cuibuwei <cuibuwei@gmail.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 2, 2024

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub changed the base branch from master to fix/typos-v0.15 December 3, 2024 23:45
@ivokub ivokub added the type: typo Typo fixes label Dec 3, 2024
@ivokub
Copy link
Copy Markdown
Collaborator

ivokub commented Dec 3, 2024

Thanks for the contribution - looks good to me! I'll wait for the CI and then merge to fix/typos-v0.15 branch. We collect smaller documentation fixes into a single branch which we merge before next release. This avoids possible merge conflicts when someone else is working on the branches.

@ivokub ivokub merged commit ee76b43 into Consensys:fix/typos-v0.15 Dec 3, 2024
ivokub pushed a commit that referenced this pull request Dec 25, 2024
Signed-off-by: cuibuwei <cuibuwei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: typo Typo fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants