feat(bw6-761): Miller loop using direct sextic extension#608
Merged
feat(bw6-761): Miller loop using direct sextic extension#608
Conversation
9 tasks
ivokub
reviewed
Jan 16, 2025
Collaborator
ivokub
left a comment
There was a problem hiding this comment.
Small cosmetic comments, otherwise looks perfect. Didn't check fully the direct mulMontgomery equations, but as the tests check compatibility with fp2fp3 tower multiplication, then should be good.
Thanks!
ivokub
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This corresponds to the gnark circuit and is needed to compute the same
residueWitnessin- and out-circuit for Consensys/gnark#1365.Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.
Added tests for the new
E6Dstruct ininternal/fptower/e6_direct_test.goand pairing computation using towered and direct extensions inpairing_test.go.How has this been benchmarked?
MillerLoopDirectis much slower thanMillerLoopbut it is only used in the hint computation for the gnark circuit.Checklist:
golangci-lintdoes not output errors locally