Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #697 by updating the BlockSize computation and corresponding memory allocation to use a dynamic calculation based on the permutation parameters rather than a constant value.
- Updated the BlockSize method to return (h.params.Width / 2)*fr.Bytes across multiple permutation implementations.
- Revised the hash initialization functions to allocate byte slices using the computed block size.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| field/koalabear/poseidon2/poseidon2.go | Updated BlockSize method to use h.params.Width / 2 * fr.Bytes |
| field/koalabear/poseidon2/hash.go | Updated Merkle Damgard hasher to use dynamic block size |
| field/goldilocks/poseidon2/poseidon2.go | Updated BlockSize method to use h.params.Width / 2 * fr.Bytes |
| field/goldilocks/poseidon2/hash.go | Revised hash initialization with dynamic block size allocation |
| field/generator/internal/templates/poseidon2/poseidon2.go.tmpl | Updated BlockSize method template to compute dynamic block size |
| field/generator/internal/templates/poseidon2/hash.go.tmpl | Updated template for hash initializer to use dynamic block size |
| field/babybear/poseidon2/poseidon2.go | Updated BlockSize method to compute dynamic block size |
| field/babybear/poseidon2/hash.go | Updated Merkle Damgard hasher to use dynamic block size allocation |
Tabaie
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # 697
Type of change
Please delete options that are not relevant.
Checklist:
golangci-lintdoes not output errors locally