Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the MerkleDamgardHasher where the IV was incorrectly re‐used on a reset, which could cause the hash to fail after a reset. The changes update the Reset method (using a safe clone of the IV), refactor state initialization via cloneLeftPadded, and add additional tests across multiple curve implementations to validate the fix.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/generator/crypto/hash/poseidon2/template/poseidon2.test.go.tmpl | Added new tests and imports to validate the MerkleDamgardHasher functionality |
| hash/merkle-damgard.go | Updated Reset and SetState to clone the IV and refactored padding logic via cloneLeftPadded |
| ecc/*/fr/poseidon2/poseidon2_test.go | Added new tests (TestHashSmall and TestHashReset) across various ECC curves to verify correct hashing behavior |
Comments suppressed due to low confidence (1)
hash/merkle-damgard.go:96
- Consider adding unit tests to verify the error handling in cloneLeftPadded when the input buffer length exceeds the expected size.
if len(b) > n {
ThomasPiellard
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect IV initialization that would make the hash fail after a
Reset.