Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the golangci-lint tool from v1.60 to v2.1.6, requiring several code changes to satisfy the stricter linting rules introduced in the newer version.
- Updated golangci-lint configuration and CI version
- Fixed API function signature to satisfy
ST1008rule (error return order) - Applied various code style fixes for cleaner linting compliance
Reviewed Changes
Copilot reviewed 121 out of 121 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Updated linter configuration to version 2 format |
| .github/workflows/pr.yml | Upgraded golangci-lint action to v8 with v2.1.6 |
| AsyncReadFrom functions | Changed return signature from (int64, error, chan error) to (int64, chan error, error) |
| Marshal functions | Simplified boolean expressions using De Morgan's laws |
| Multiple files | Added nolint comments for specific QF rules and improved code style |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gbotrel
requested changes
Aug 21, 2025
Collaborator
gbotrel
left a comment
gbotrel
left a comment
There was a problem hiding this comment.
a part from the API change on vector method, all good with me 👍
This reverts commit 6237a19.
gbotrel
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
golangci-linttov2.1.6.Some changes were made to satisfy the now-stricter
staticchecklinter.WARNING:
ST1008has been ignored because the fix would involve an API change:to become