fix: reintroduce BitReverse in fft package as deprecated for backward…#740
Merged
fix: reintroduce BitReverse in fft package as deprecated for backward…#740
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces the BitReverse function to individual field FFT packages as deprecated wrapper functions to maintain backward compatibility. A previous PR #736 removed these functions causing breaking changes for upstream users.
- Adds deprecated
BitReversewrapper functions to all field FFT packages - Updates the code generation template to include the deprecated function
- Maintains backward compatibility while directing users to the new
utils.BitReverseimplementation
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| field/generator/internal/templates/fft/domain.go.tmpl | Updates template to generate deprecated BitReverse wrapper in all field packages |
| field/koalabear/fft/domain.go | Adds deprecated BitReverse wrapper function |
| field/goldilocks/fft/domain.go | Adds deprecated BitReverse wrapper function |
| field/babybear/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bw6-761/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bw6-633/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bn254/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bls24-317/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bls24-315/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bls12-381/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
| ecc/bls12-377/fr/fft/domain.go | Adds deprecated BitReverse wrapper function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return read, nil | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] Remove the extra blank line at line 315. There should only be one blank line before the function documentation.
Suggested change
gbotrel
added a commit
that referenced
this pull request
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous #736 PR made upstream usage break (...) since it removed the
BitReversefunction from the individual field fft pacakges. Added in back as deprecated.