Skip to content

CI: Standardize imports#760

Merged
Tabaie merged 3 commits intomasterfrom
ci/goimports
Oct 23, 2025
Merged

CI: Standardize imports#760
Tabaie merged 3 commits intomasterfrom
ci/goimports

Conversation

@Tabaie
Copy link
Copy Markdown
Contributor

@Tabaie Tabaie commented Oct 21, 2025

Adds goimports to code generation and PR checks.


Note

Enforces goimports in CI and code generation, standardizing import ordering/aliases across the codebase.

  • CI:
    • Add goimports check to /.github/workflows/pr.yml and /.github/workflows/push.yml.
  • Code generation:
    • Run goimports in internal/generator/main.go after formatting steps.
  • Repo-wide imports:
    • Normalize import ordering and add aliases per goimports across many files (no logic changes).

Written by Cursor Bugbot for commit 7aa8796. This will update automatically on new commits. Configure here.

@Tabaie Tabaie marked this pull request as ready for review October 21, 2025 21:29
cursor[bot]

This comment was marked as outdated.

@Tabaie Tabaie requested a review from gbotrel October 21, 2025 21:33
Copy link
Copy Markdown
Collaborator

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍 since now we are at go 1.24+ may be worth to add this as tool ( https://go.dev/ref/mod#go-mod-file-tool ) . same for asmfmt etc.

@Tabaie Tabaie merged commit 245ea9c into master Oct 23, 2025
7 checks passed
@Tabaie Tabaie deleted the ci/goimports branch October 23, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants