Merged
Conversation
gbotrel
reviewed
Apr 7, 2022
| // last round, provide the evaluation. The fully folded polynomial is of size rho. It should | ||
| // correspond to the evaluation of a polynomial of degree 1 on ρ points, so those points | ||
| // are supposed to be on a line. | ||
| res.evaluation = make([]fr.Element, rho) |
Collaborator
There was a problem hiding this comment.
if rho is a constant, evaluation should be an array of size rho in the struct, not a slice
| // point and its neighbor. | ||
| c := si[i] % 2 | ||
| res.interactions[i][c] = partialMerkleProof{mr, proofSet, numLeaves} | ||
| res.interactions[i][1-c] = partialMerkleProof{ |
Contributor
Author
There was a problem hiding this comment.
no, here c is 0 or 1 here. The c-th entry contains the full Merkle path, the (1-c)-th the partial Merkle path.
gbotrel
reviewed
Apr 7, 2022
|
|
||
| properties := gopter.NewProperties(parameters) | ||
|
|
||
| size := 4096 |
Collaborator
There was a problem hiding this comment.
remark; shouldn't his vary during the tests?
Similarly, randomPolynomial is not super random; (ie always the same form with coeff squared)
gbotrel
reviewed
Apr 7, 2022
|
|
||
| const rho = 8 | ||
|
|
||
| var NbRounds = 1 |
Collaborator
There was a problem hiding this comment.
is it a constant? if it's not, should be made a parameter to the functions where it's needed.
gbotrel
reviewed
Apr 7, 2022
|
|
||
| var NbRounds = 1 | ||
|
|
||
| // var ErrorRate float32 |
gbotrel
approved these changes
Apr 8, 2022
Collaborator
|
@yelhousni can you review before merge? |
gbotrel
reviewed
May 23, 2022
| // "testing" | ||
| // ) | ||
|
|
||
| // func TestMimc(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
@ThomasPiellard why is this commented / in the PR ?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A basic version of the FRI protocol is now available, in ecc/curve/fr/fri.
The multiplicative version only has been implemented, it works on the prime-order subgroup of the corresponding curves.
The version is not tunable yet (only by hand), and should not be used unless careful choice of the parameters (e.g. rho, the number of rounds of verification) have been made.
It provides a working base for future work on FRI (possibly using ECFFT).
API
example:
Internally, a proof of proximity is a sequence of interactions between a prover and a verifier (made non interactive using Fiat Shamir), where each interaction consists of a Merkle path proof verification, and a consistancy check between one round to the next.