Remove labelsCaptured logic

Author: szegedi

bindings/profilers/wall.cc

@@ -573,10 +573,6 @@ NAN_MODULE_INIT(WallProfiler::Init) {
                    GetLabels,
                    SetLabels);
 
-  Nan::SetAccessor(tpl->InstanceTemplate(),
-                   Nan::New("labelsCaptured").ToLocalChecked(),
-                   GetLabelsCaptured);
-
   Nan::SetPrototypeMethod(tpl, "start", Start);
   Nan::SetPrototypeMethod(tpl, "dispose", Dispose);
   Nan::SetPrototypeMethod(tpl, "stop", Stop);
@@ -625,19 +621,11 @@ NAN_SETTER(WallProfiler::SetLabels) {
   profiler->SetLabels(info.GetIsolate(), value);
 }
 
-NAN_GETTER(WallProfiler::GetLabelsCaptured) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
-  info.GetReturnValue().Set(profiler->GetLabelsCaptured());
-}
-
 void WallProfiler::PushContext(int64_t time_from) {
   // Be careful this is called in a signal handler context therefore all
   // operations must be async signal safe (in particular no allocations). Our
   // ring buffer avoids allocations.
   contexts.push_back(SampleContext(labels_, time_from, v8::base::TimeTicks::Now()));
-  if (labels_) {
-    labelsCaptured = true;
-  }
 }
 
 }  // namespace dd

bindings/profilers/wall.hh

@@ -23,7 +23,6 @@ class WallProfiler : public Nan::ObjectWrap {
   // avoid heap allocation. Need to figure out the right move/copy semantics in
   // and out of the ring buffer.
   ValuePtr labels_;
-  bool labelsCaptured = false;
 
   struct SampleContext {
     ValuePtr labels;
@@ -59,7 +58,6 @@ class WallProfiler : public Nan::ObjectWrap {
 
   v8::Local<v8::Value> GetLabels(v8::Isolate*);
   void SetLabels(v8::Isolate*, v8::Local<v8::Value>);
-  bool GetLabelsCaptured() { return std::exchange(labelsCaptured, false); }
 
   void PushContext(int64_t time_from);
   void StartImpl(v8::Local<v8::String> name,
@@ -75,7 +73,6 @@ class WallProfiler : public Nan::ObjectWrap {
   static NAN_MODULE_INIT(Init);
   static NAN_GETTER(GetLabels);
   static NAN_SETTER(SetLabels);
-  static NAN_GETTER(GetLabelsCaptured);
 };
 
 }  // namespace dd

ts/src/time-profiler.ts

@@ -111,8 +111,7 @@ function startInternal(
   let runName = start();
   return {
     stop: majorVersion < 16 ? stopOld : stop,
-    setLabels,
-    labelsCaptured,
+    setLabels
   };
 
   function start() {
@@ -152,8 +151,4 @@ function startInternal(
   function setLabels(labels?: LabelSet) {
     profiler.labels = labels;
   }
-
-  function labelsCaptured() {
-    return profiler.labelsCaptured;
-  }
 }