No need for unsetLabels

Author: szegedi

bindings/profilers/wall.cc

@@ -542,7 +542,6 @@ NAN_MODULE_INIT(WallProfiler::Init) {
   Nan::SetPrototypeMethod(tpl, "start", Start);
   Nan::SetPrototypeMethod(tpl, "dispose", Dispose);
   Nan::SetPrototypeMethod(tpl, "stop", Stop);
-  Nan::SetPrototypeMethod(tpl, "unsetLabels", UnsetLabels);
 
   PerIsolateData::For(Isolate::GetCurrent())
       ->WallProfilerConstructor()
@@ -571,11 +570,11 @@ v8::Local<v8::Value> WallProfiler::GetLabels(Isolate* isolate) {
 }
 
 void WallProfiler::SetLabels(Isolate* isolate, Local<Value> value) {
-  labels_ = std::make_shared<Global<Value>>(isolate, value);
-}
-
-void WallProfiler::UnsetLabels() {
-  labels_.reset();
+  if (value->BooleanValue(isolate)) {
+    labels_ = std::make_shared<Global<Value>>(isolate, value);
+  } else {
+    labels_.reset();
+  }
 }
 
 NAN_GETTER(WallProfiler::GetLabels) {
@@ -588,11 +587,6 @@ NAN_SETTER(WallProfiler::SetLabels) {
   profiler->SetLabels(info.GetIsolate(), value);
 }
 
-NAN_METHOD(WallProfiler::UnsetLabels) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
-  profiler->UnsetLabels();
-}
-
 NAN_GETTER(WallProfiler::GetLabelsCaptured) {
   auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
   info.GetReturnValue().Set(profiler->GetLabelsCaptured());

bindings/profilers/wall.hh

@@ -68,7 +68,6 @@ class WallProfiler : public Nan::ObjectWrap {
 
   v8::Local<v8::Value> GetLabels(v8::Isolate*);
   void SetLabels(v8::Isolate*, v8::Local<v8::Value>);
-  void UnsetLabels();
   bool GetLabelsCaptured() {
     bool captured = labelsCaptured;
     labelsCaptured = false;
@@ -83,7 +82,6 @@ class WallProfiler : public Nan::ObjectWrap {
   static NAN_METHOD(Dispose);
   static NAN_METHOD(Start);
   static NAN_METHOD(Stop);
-  static NAN_METHOD(UnsetLabels);
   static NAN_MODULE_INIT(Init);
   static NAN_GETTER(GetLabels);
   static NAN_SETTER(SetLabels);

ts/src/time-profiler.ts

@@ -75,7 +75,6 @@ export function start(
   return {
     stop: majorVersion < 16 ? stopOld : stop,
     setLabels,
-    unsetLabels,
     labelsCaptured,
   };
 
@@ -117,10 +116,6 @@ export function start(
     profiler.labels = labels;
   }
 
-  function unsetLabels() {
-    profiler.unsetLabels();
-  }
-
   function labelsCaptured() {
     return profiler.labelsCaptured;
   }