Silence agent6_extra_options notification on default params (#449)

* Silence agent6_extra_options notification on default params

* Add specs to check for extraneous notifys

Author: spectralblu

manifests/init.pp

@@ -534,16 +534,16 @@
     }
   } else {
     # notify of broken params on agent6
-    if $proxy_host {
+    if !empty($proxy_host) {
         notify { 'Setting proxy_host will have no effect on agent6 please use agent6_extra_options to set your proxy': }
     }
-    if $_proxy_port {
+    if !empty($_proxy_port) {
         notify { 'Setting proxy_port will have no effect on agent6 please use agent6_extra_options to set your proxy': }
     }
-    if $proxy_user {
+    if !empty($proxy_user) {
         notify { 'Setting proxy_user will have no effect on agent6 please use agent6_extra_options to set your proxy': }
     }
-    if $proxy_password {
+    if !empty($proxy_password) {
         notify { 'Setting proxy_password will have no effect on agent6 please use agent6_extra_options to set your proxy': }
     }
 

spec/classes/datadog_agent_spec.rb

@@ -979,6 +979,26 @@
                   'Setting proxy_password will have no effect on agent6 please use agent6_extra_options to set your proxy') 
               }
             end
+            context 'deprecated proxy settings with default values' do
+              let(:params) {{
+                  :proxy_host => '',
+                  :proxy_port => '',
+                  :proxy_user => '',
+                  :proxy_password => '',
+              }}
+              it { is_expected.not_to contain_notify(
+                  'Setting proxy_host will have no effect on agent6 please use agent6_extra_options to set your proxy')
+              }
+              it { is_expected.not_to contain_notify(
+                  'Setting proxy_port will have no effect on agent6 please use agent6_extra_options to set your proxy')
+              }
+              it { is_expected.not_to contain_notify(
+                  'Setting proxy_user will have no effect on agent6 please use agent6_extra_options to set your proxy')
+              }
+              it { is_expected.not_to contain_notify(
+                  'Setting proxy_password will have no effect on agent6 please use agent6_extra_options to set your proxy')
+              }
+            end
           end
 
           context 'with additional agents config' do