upgrade to Puppet 8 and PDK version to 3.4 (#823)

* add parameter data types, fix whitespacing, remove legacy facts, remove legacy :: referencing. Changes for Puppet 8

* update linting rules

* added missing data types, removed optional when we defaulting things. prettied the code.

* add default extensions

* optional param should not be optional if using default. prettied things

* now that we support Puppet 8, we should support stdlib v9. add linting no check for empty strings

* upgrade pdk version to 3.4

* controlling versions of io-console (as 0.8 is built for Ruby 3.3) and bcrypt_pbkdf 1.1 fails to install with Ruby 3.2.5

* update the reference to concat to support later versions of stdlib

* update to new stdlib function

* fixes requested by code review

* remove deprecated function, moving to is_a

* version comparison is working with a int not a string

* making optional following code review

* revert versioncmp changes made by pdk validate

* removing linting check for use of versioning as we use integers for versionning not strings

* update module dependencies to support Puppet 8

* fixed class documentation and made params optional

* fix all optional references to undef calls. fix warnings about no class docs due to space between class declaration and docs

* fix for unless command

* fix pdk validation warnings

* made sitename required

* making url required.

* correcting default on min collection interval

* making check name required.

* making host required

* making port required

* fix gemfile for ruby < 3.1 and puppet 7; bump bundler to v2.4.13 in CI

* update deps

* exclude EOL versions from CI

* update gemfile.lock and .gitignore

* Convert unless command into HereDoc command, fix issue where MSI path is not passed correctly.

* Update to change log and version

* fix config

* update ci specs

* use ruby 2.6+ puppet 6.5+ in ci

* remove gemfile.lock before installing bundler

* clean up circleci, update gemfile.lock

* rm .vscode

* use ruby 2.7+ puppet 6.5+ in ci

* update Gemfile.lock

* debug bundler version

* add linux deps for ci

* config.yml cleanup

* review suggestions

* update gemfile.lock and target ruby version for rubocop

* merge changes from pr

* elastic search now uses tls_verify rather than ssl_verify. Breaking, as this no longer supports a String.

* update change log inline with change suggested for tls_verify

* update gem following vuln check

* added back in missing comma

* fix tls/ssl verify in tests

* update kitchen tests

* update kitchen ruby version

* update env/Gemfile

* update env/Gemfile

* try using ruby v3.1

* add more unit test specs and bump versions

* bump kitchen ubuntu and ruby versions

* use ubuntu2204 for kitchen tests

* workaround for tmp directory mounted noexec issue

* use recursive chmod

* disable ruby v3.4 unit test specs

* remove puppetserver and bump module deps

* remove puppetserver and bump module deps for kitchen tests

* use ruby v3.3 for gemfile.lock test

* bump rexml and use serverspec as kitchen verifier

* remove chmod /tmp

* revert kitchen changes -- being handled in PR #4

* add links to docs

* fix bug with $ not being escaped. Updated Change log with latest changes

* remove custom metrics

* update to support sitename and url being required

* removed test for passing simple string with tags. It must be an array as per definition.

* fix issues for robocop

* add missing params section to http_check test

* add note about default value.

* updating defaults inline with class defaults.

* fix tests to match default values

* fix tcp checks given required params

* correct test to provide correct datatype. corrected array to match datatype requirements

* fixing incorrect change to test

* updating test to match default

* removing test, as check does not work however following test does check tags exists with correct value.

* fix regex check

* attempting to correctly reference the hash within the array of instances

* remove puppet 6 unit test specs

* bump windows orb

* The ganglia feature has been removed and not supported in Agent 6+

* tcp check's skip_event setting is no longer supported, so we have removed it from the module

* tcp check's collect response time is a boolean not a integer

* puppet_litmus v1 does not support ruby 3

* adding in default fact to fix unit test

* correct fact syntax

* move to non deprecated function for ensure_packages

* removed deprecated function validate_legacy. Improved error message

* using a different syntax for fact to match rest of file

* fix(http-check): Allow multiple instances to be passed

* fix tests

* fix tests

* remove agent 5

* fix rubocop target ruby version

* remote --autocorrect from .rubocop

* add facter and kitchen-puppet gems to kitchen gemfile, disable centos stream kitchen tests

* temporarily disable rocky 9 kitchen tests

* fix ubuntu kitchen tests

* clean up doc as per markdown rules. add note about breaking change for disk class

* disable rubocop Style/HashSyntax for reporting events

* fix: Corrected type of service_enable param

* update to release notes

* fix kitchen tests

* clean up integrations manifests

* clean up integrations specs

* clean up more manifests

* update rocky image

* cleanup

* update deprecated ensure_packages function

* fail installation for agent 5

* updated change log to state removal of SSL settings from Redis integration

* update with note about postgres

* add back multi-instances fix

* address linter warnings

* align spaces

* add back redis ssl

* remove comment following revert of redis change

* fix postgres and elastic

* update docs, cleanups

* fix changelog, readme

* update readme

* make note of breaking changes in readme

* Apply suggestions from code review

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

* fix suppress_errors

* update changelog, readme, metadata

---------

Co-authored-by: Darren Gipson <darren.gipson@towerswatson.com>
Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com>
Co-authored-by: Niels Tholenaar <nielstholenaar@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

Author: 5 people

.circleci/config.yml

@@ -1,27 +1,24 @@
 fixtures:
   repositories:
     stdlib:
-      repo: "git://github.com/puppetlabs/puppetlabs-stdlib.git"
-      ref: "4.25.0"
+      repo: "https://github.com/puppetlabs/puppetlabs-stdlib.git"
+      ref: "v9.7.0" # Puppet >= 7.0.0 < 9.0.0
     concat:
-      repo: "git://github.com/puppetlabs/puppetlabs-concat.git"
-      ref: "4.1.1"
+      repo: "https://github.com/puppetlabs/puppetlabs-concat.git"
+      ref: "v9.1.0" # Puppet >= 7.0.0 < 9.0.0
     apt:
-      repo: "git://github.com/puppetlabs/puppetlabs-apt.git"
-      ref: "4.5.0"
-    puppetserver_gem:
-      repo: "git://github.com/puppetlabs/puppetlabs-puppetserver_gem.git"
-      ref: "1.0.0"
+      repo: "https://github.com/puppetlabs/puppetlabs-apt.git"
+      ref: "v10.0.1" # Puppet >= 7.0.0 < 9.0.0
   forge_modules:
     yumrepo_core:
       repo: "puppetlabs/yumrepo_core"
-      ref: "1.2.0"
+      ref: "2.1.0"
     powershell:
       repo: "puppetlabs/powershell"
-      ref: "4.1.0"
+      ref: "6.0.2"
     zypprepo:
       repo: "puppet/zypprepo"
-      ref: "3.1.0"
+      ref: "5.0.0"
   symlinks:
     custom_datadog: "#{source_dir}/spec/custom_fixtures/custom_datadog"
     datadog_agent: "#{source_dir}"

.fixtures.yml

@@ -14,8 +14,11 @@
 /junit/
 /log/
 /pkg/
+/spec/fixtures/manifests/
+/spec/fixtures/modules/*
 /tmp/
 /vendor/
+/.vendor/
 /convert_report.txt
 /update_report.txt
 spec/fixtures
@@ -32,4 +35,11 @@ environments/**/.vagrant
 /inventory.yaml
 
 .kitchen
-.vscode
+
+/spec/fixtures/litmus_inventory.yaml
+.resource_types
+.modules
+.task_cache.json
+.plan_cache.json
+.rerun.json
+bolt-debug.log

.gitignore

@@ -16,30 +16,42 @@
 /log/
 /pkg/
 /spec/fixtures/manifests/
-/spec/fixtures/modules/
+/spec/fixtures/modules/*
 /tmp/
 /vendor/
+/.vendor/
 /convert_report.txt
 /update_report.txt
 .DS_Store
 .project
 .envrc
 /inventory.yaml
-/appveyor.yml
+/spec/fixtures/litmus_inventory.yaml
+.resource_types
+.modules
+.task_cache.json
+.plan_cache.json
+.rerun.json
+bolt-debug.log
 /.fixtures.yml
 /Gemfile
 /.gitattributes
+/.github/
 /.gitignore
 /.gitlab-ci.yml
+
 /.pdkignore
+/.puppet-lint.rc
 /Rakefile
 /rakelib/
 /.rspec
 /.rubocop.yml
 /.travis.yml
+/..yml
 /.yardopts
 /spec/
-/.vscode/
+/.sync.yml
+/.devcontainer/
 /.github/
 /.circleci/
 /.pre-commit-config.yaml

.pdkignore

@@ -1,3 +1,13 @@
+--fail-on-warnings
 --relative
+--no-80chars-check
 --no-140chars-check
---fail-on-warnings
+--no-class_inherits_from_params_class-check
+--no-autoloader_layout-check
+--no-parameter_documentation-check
+--no-single_quote_string_with_variables-check
+--no-params_empty_string_assignment-check
+--no-lookup_in_parameter-check
+--no-version_comparison-check
+--no-top_scope_facts-check
+--ignore-paths=.vendor/**/*.pp,.bundle/**/*.pp,pkg/**/*.pp,spec/**/*.pp,tests/**/*.pp,types/**/*.pp,vendor/**/*.pp

.puppet-lint.rc

@@ -0,0 +1,2 @@
+--color
+--format documentation

.rspec

@@ -0,0 +1 @@
+--ignore-unrecognized-cops