Addressing metaparam override in datadog_agent::tag (#338)

Author: craigwatson

manifests/tag.pp

@@ -1,28 +1,28 @@
 # Allow custom tags via a define
 define datadog_agent::tag(
-  $tag = $name,
+  $tag_name = $name,
   $lookup_fact = false,
 ){
 
   if $lookup_fact{
-    $value = getvar($tag)
+    $value = getvar($tag_name)
 
     if is_array($value){
-      $tags = prefix($value, "${tag}:")
+      $tags = prefix($value, "${tag_name}:")
       datadog_agent::tag{$tags: }
     } else {
       if $value {
-        concat::fragment{ "datadog tag ${tag}:${value}":
+        concat::fragment{ "datadog tag ${tag_name}:${value}":
           target  => '/etc/dd-agent/datadog.conf',
-          content => "${tag}:${value}, ",
+          content => "${tag_name}:${value}, ",
           order   => '03',
         }
       }
     }
   } else {
-    concat::fragment{ "datadog tag ${tag}":
+    concat::fragment{ "datadog tag ${tag_name}":
       target  => '/etc/dd-agent/datadog.conf',
-      content => "${tag}, ",
+      content => "${tag_name}, ",
       order   => '03',
     }
   }