Multiple fixes to Kafka, Consul, stdlib deprecations (#404)

* [kafka] adding Agent6 support

* [consul][spec] adding more extensive tests

* [functions] remove legacy validations

* [manifest] more stdlib 4.24.0 deprecation fixes

* [agent6] fix tagging.

* [legacy] fix tests for older rubies

* [apt][metadata] dropping lower bound to 2.4.0 for increased compatibility

* [functions] fix typo in tag6, use variable in recursion

Author: truthbk

functions/tag6.pp

@@ -6,20 +6,27 @@ function datadog_agent::tag6(
   Variant[Array, String] $tag_names,
   Variant[String, Boolean] $lookup_fact = false,
 ) {
-  if validate_legacy('Optional[Array]', 'is_array', $tag_names) {
+  if $tag_names =~ Array {
     $tags = $tag_names.reduce([]) |$_tags , $tag| {
-        concat($_tags, datadog_agent::tag6($tag, lookup_fact))
+        concat($_tags, datadog_agent::tag6($tag, $lookup_fact))
+    }
+  } else {
+    if $lookup_fact =~ String {
+      $lookup = str2bool($lookup_fact)
+    } else {
+      $lookup = $lookup_fact
     }
-  } elsif str2bool($lookup_fact) {
-    $value = getvar($tag_names)
 
-    if validate_legacy('Optional[Array]', 'is_array', $value){
-      $tags = prefix($value, "${tag_names}:")
+    if $lookup {
+      $value = getvar($tag_names)
+      if $value =~ Array {
+        $tags = prefix($value, "${tag_names}:")
+      } else {
+        $tags = [$tag_names]
+      }
     } else {
       $tags = [$tag_names]
     }
-  } else {
-    $tags = [$tag_names]
   }
 
   $tags

manifests/init.pp

@@ -525,7 +525,7 @@
       'dogstatsd_non_local_traffic' => $non_local_traffic,
       'log_file' => $agent6_log_file,
       'log_level' => $log_level,
-      'tags' => union($_local_tags, $_facts_tags),
+      'tags' => unique(flatten(union($_local_tags, $_facts_tags))),
     }
 
     $agent_config = deep_merge($_agent_config, $extra_config)

manifests/integration.pp

@@ -6,11 +6,9 @@
 
   include datadog_agent
 
-  validate_array($instances)
-  if $init_config != undef {
-    validate_hash($init_config)
-  }
-  validate_string($integration)
+  validate_legacy(Array, 'validate_array', $instances)
+  validate_legacy(Optional[Hash], 'validate_hash', $init_config)
+  validate_legacy(String, 'validate_string', $integration)
 
   if !$::datadog_agent::agent5_enable {
     $dst = "${datadog_agent::conf6_dir}/${integration}.yaml"

manifests/integrations/apache.pp

@@ -35,9 +35,9 @@
 ) inherits datadog_agent::params {
   include datadog_agent
 
-  validate_string($url)
-  validate_array($tags)
-  validate_bool($disable_ssl_validation)
+  validate_legacy('String', 'validate_string', $url)
+  validate_legacy('Array', 'validate_array', $tags)
+  validate_legacy('Boolean', 'validate_bool', $disable_ssl_validation)
 
   if !$::datadog_agent::agent5_enable {
     $dst = "${datadog_agent::conf6_dir}/apache.yaml"

manifests/integrations/cassandra.pp

@@ -33,7 +33,8 @@
   $tags = {},
 ) inherits datadog_agent::params {
   require ::datadog_agent
-  validate_hash($tags)
+
+  validate_legacy(Optional[Hash], 'validate_hash', $tags)
 
   if !$::datadog_agent::agent5_enable {
     $dst = "${datadog_agent::conf6_dir}/cassandra.yaml"

manifests/integrations/ceph.pp

@@ -14,12 +14,13 @@
 #  }
 #
 class datadog_agent::integrations::ceph(
-  $tags = [ 'name:ceph_cluster' ],
-  $ceph_cmd = '/usr/bin/ceph',
+  Array $tags = [ 'name:ceph_cluster' ],
+  String $ceph_cmd = '/usr/bin/ceph',
 ) inherits datadog_agent::params {
   include datadog_agent
 
-  validate_array($tags)
+  validate_legacy('Array', 'validate_array', $tags)
+  validate_legacy('String', 'validate_string', $ceph_cmd)
 
   file { '/etc/sudoers.d/datadog_ceph':
     content => "# This file is required for dd ceph \ndd-agent ALL=(ALL) NOPASSWD:/usr/bin/ceph\n"

manifests/integrations/consul.pp

@@ -27,18 +27,18 @@
 #   }
 #
 class datadog_agent::integrations::consul(
-  $url                    = 'http://localhost:8500',
-  $catalog_checks         = true,
-  $network_latency_checks = true,
-  $new_leader_checks      = true,
-  $service_whitelist      = []
+  String $url                        = 'http://localhost:8500',
+  Boolean $catalog_checks            = true,
+  Boolean $network_latency_checks    = true,
+  Boolean $new_leader_checks         = true,
+  Optional[Array] $service_whitelist = []
 ) inherits datadog_agent::params {
   include datadog_agent
 
-  validate_string($url)
-  validate_bool($catalog_checks)
-  validate_bool($new_leader_checks)
-  validate_array($service_whitelist)
+  validate_legacy('String', 'validate_string', $url)
+  validate_legacy('Boolean', 'validate_bool', $catalog_checks)
+  validate_legacy('Boolean', 'validate_bool', $new_leader_checks)
+  validate_legacy('Optional[Array]', 'validate_array', $service_whitelist)
 
   if !$::datadog_agent::agent5_enable {
     $dst = "${datadog_agent::conf6_dir}/consul.yaml"

manifests/integrations/directory.pp

@@ -55,22 +55,22 @@
 # }
 
 class datadog_agent::integrations::directory (
-  $directory   = '',
-  $filegauges  = false,
-  $recursive   = true,
-  $countonly   = false,
-  $nametag     = '',
-  $dirtagname  = '',
-  $filetagname = '',
-  $pattern     = '',
-  $instances   = undef,
+  String $directory          = '',
+  Boolean $filegauges        = false,
+  Boolean $recursive         = true,
+  Boolean $countonly         = false,
+  String $nametag            = '',
+  String $dirtagname         = '',
+  String $filetagname        = '',
+  String $pattern            = '',
+  Optional[Array] $instances = undef,
 ) inherits datadog_agent::params {
   include datadog_agent
 
-  validate_string($directory)
-  validate_bool($filegauges)
-  validate_bool($recursive)
-  validate_bool($countonly)
+  validate_legacy(String, 'validate_string', $directory)
+  validate_legacy(Boolean, 'validate_bool', $filegauges)
+  validate_legacy(Boolean, 'validate_bool', $recursive)
+  validate_legacy(Boolean, 'validate_bool', $countonly)
 
   if !$instances and $directory == '' {
     fail('bad directory argument and no instances hash provided')

manifests/integrations/disk.pp

@@ -32,7 +32,7 @@
 #      excluded_disk_re     => '/dev/sd[e-z]*'
 #  }
 class datadog_agent::integrations::disk (
-  $use_mount              = 'no',
+  String $use_mount       = 'no',
   $excluded_filesystems   = undef,
   $excluded_disks         = undef,
   $excluded_disk_re       = undef,
@@ -42,9 +42,10 @@
 ) inherits datadog_agent::params {
   include datadog_agent
 
-  validate_re($use_mount, '^(no|yes)$', "use_mount should be either 'yes' or 'no'")
-  if $all_partitions {
-    validate_re($all_partitions, '^(no|yes)$', "all_partitions should be either 'yes' or 'no'")
+  validate_legacy('Optional[String]', 'validate_re', $all_partitions, '^(no|yes)$')
+
+  if $use_mount !~ '^(no|yes)$' {
+    fail('error during compilation')
   }
 
   if !$::datadog_agent::agent5_enable {

manifests/integrations/dns_check.pp

@@ -25,7 +25,7 @@
 #  }
 #
 class datadog_agent::integrations::dns_check (
-  $checks = [
+  Array $checks = [
     {
       'hostname'   => 'google.com',
       'nameserver' => '8.8.8.8',
@@ -35,7 +35,7 @@
 ) inherits datadog_agent::params {
   include datadog_agent
 
-  validate_array($checks)
+  validate_legacy('Array', 'validate_array', $checks)
 
   if !$::datadog_agent::agent5_enable {
     $dst = "${datadog_agent::conf6_dir}/dns_check.yaml"