Added http_responce_status_code to http_check module integration (#290)

* Added http_responce_status_code to http_check module integration

* [spec] adding tests for http_response_status_code.

Author: dzinek

manifests/integrations/http_check.pp

@@ -37,6 +37,13 @@
 #       check to create a metric 'network.http.response_time', tagged with
 #       the url, reporting the response time in seconds.
 #
+#   http_response_status_code
+#       The (optional) http_response_status_code parameter will instruct the check
+#       to look for a particular HTTP response status code or a Regex identifying
+#       a set of possible status codes.
+#       The check will report as DOWN if status code returned differs.
+#       This defaults to 1xx, 2xx and 3xx HTTP status code: (1|2|3)\d\d.
+#
 #   collect_response_time
 #       The (optional) collect_response_time parameter will instruct the
 #       check to create a metric 'network.http.response_time', tagged with
@@ -144,6 +151,7 @@
   $window    = undef,
   $content_match = undef,
   $include_content = false,
+  $http_response_status_code = undef,
   $collect_response_time = true,
   $disable_ssl_validation = false,
   $skip_event = true,
@@ -169,6 +177,7 @@
       'window'                       => $window,
       'content_match'                => $content_match,
       'include_content'              => $include_content,
+      'http_response_status_code'    => $http_response_status_code,
       'collect_response_time'        => $collect_response_time,
       'disable_ssl_validation'       => $disable_ssl_validation,
       'skip_event'                   => $skip_event,

spec/classes/datadog_agent_integrations_http_check_spec.rb

@@ -31,6 +31,7 @@
     it { should contain_file(conf_file).without_content(%r{content_match: }) }
     it { should contain_file(conf_file).without_content(%r{include_content: true}) }
     it { should contain_file(conf_file).without_content(%r{collect_response_time: true}) }
+    it { should contain_file(conf_file).without_content(%r{http_response_status_code: }) }
     it { should contain_file(conf_file).without_content(%r{disable_ssl_validation: false}) }
     it { should contain_file(conf_file).without_content(%r{skip_event: }) }
     it { should contain_file(conf_file).without_content(%r{no_proxy: }) }
@@ -55,6 +56,7 @@
       collect_response_time: false,
       disable_ssl_validation: true,
       skip_event: true,
+      http_response_status_code: '503',
       no_proxy: true,
       check_certificate_expiration: true,
       days_warning: 14,
@@ -73,6 +75,7 @@
     it { should contain_file(conf_file).without_content(%r{collect_response_time: true}) }
     it { should contain_file(conf_file).with_content(%r{disable_ssl_validation: true}) }
     it { should contain_file(conf_file).with_content(%r{skip_event: true}) }
+    it { should contain_file(conf_file).with_content(%r{http_response_status_code: 503}) }
     it { should contain_file(conf_file).with_content(%r{no_proxy: true}) }
     it { should contain_file(conf_file).with_content(%r{check_certificate_expiration: true}) }
     it { should contain_file(conf_file).with_content(%r{days_warning: 14}) }

templates/agent-conf.d/http_check.yaml.erb

@@ -25,6 +25,9 @@ instances:
 <% if instance['include_content'] -%>
     include_content: <%= instance['include_content'] %>
 <% end -%>
+<% if instance['http_response_status_code'] -%>
+    http_response_status_code: <%= instance['http_response_status_code'] %>
+<% end -%>
 <% if instance['collect_response_time'] -%>
     collect_response_time: <%= instance['collect_response_time'] %>
 <% end -%>