Fix passing tags to msiexec (#661)

* Testing an inline transform to fix tag arrays using msiexec

* Converting the array to a quoted string separated by commas, else msiexec opens a gui error message and hangs the puppet run when the $tags array has more than one member.

* Puppet lint fixes

Co-authored-by: Alex Berry <alexb@directferries.com>

Author: alexberry

manifests/windows.pp

@@ -11,6 +11,8 @@
   String $api_key = $datadog_agent::api_key,
   String $hostname = $datadog_agent::host,
   Array  $tags = $datadog_agent::tags,
+  String $tags_join = join($tags,','),
+  String $tags_quote_wrap = "\"${tags_join}\"",
   Enum['present', 'absent'] $ensure = 'present',
 ) inherits datadog_agent::params {
 
@@ -67,7 +69,7 @@
       ensure          => $ensure_version,
       provider        => 'windows',
       source          => $msi_full_path,
-      install_options => ['/norestart', {'APIKEY' => $api_key, 'HOSTNAME' => $hostname, 'TAGS' => $tags}]
+      install_options => ['/norestart', {'APIKEY' => $api_key, 'HOSTNAME' => $hostname, 'TAGS' => $tags_quote_wrap}]
     }
 
   } else {