Add parameters to ceph integration (#322)

Closes: #321

Author: stamak

manifests/integrations/ceph.pp

@@ -3,16 +3,24 @@
 # This class will install the necessary configuration for the ceph integration
 #
 # Parameters:
+#   $tags
+#       Optional array of tags
+#   $ceph_cmd
+#       Optional ceph cmd
 
 # Sample Usage:
 #
 #  class { 'datadog_agent::integrations::ceph' :
 #  }
 #
 class datadog_agent::integrations::ceph(
+  $tags = [ 'name:ceph_cluster' ],
+  $ceph_cmd = '/usr/bin/ceph',
 ) inherits datadog_agent::params {
   include datadog_agent
 
+  validate_array($tags)
+
   file { '/etc/sudoers.d/datadog_ceph':
     content => "# This file is required for dd ceph \ndd-agent ALL=(ALL) NOPASSWD:/usr/bin/ceph\n"
   }

spec/classes/datadog_agent_integrations_ceph_spec.rb

@@ -28,4 +28,24 @@
     it { should contain_file(sudo_conf_file).with_content(/^dd-agent\sALL=.*NOPASSWD:\/usr\/bin\/ceph$/) }
   end
 
+  context 'with specified tag' do
+    let(:params) {{
+      tags: ['name:my_ceph_cluster'],
+    }}
+    it { should contain_file(conf_file).with_content(/tags:\s+- name:my_ceph_cluster\s*?[^-]/m) }
+    it { should contain_file(conf_file).with_content(/^\s*ceph_cmd:\s*\/usr\/bin\/ceph\s*?[^-]/m) }
+    it { should contain_file(conf_file).with_content(/^\s*use_sudo:\sTrue$/) }
+    it { should contain_file(sudo_conf_file).with_content(/^dd-agent\sALL=.*NOPASSWD:\/usr\/bin\/ceph$/) }
+  end
+
+  context 'with specified ceph_cmd' do
+    let(:params) {{
+      ceph_cmd: '/usr/local/myceph',
+    }}
+    it { should contain_file(conf_file).with_content(/tags:\s+- name:ceph_cluster\s*?[^-]/m) }
+    it { should contain_file(conf_file).with_content(/^\s*ceph_cmd:\s*\/usr\/local\/myceph\s*?[^-]/m) }
+    it { should contain_file(conf_file).with_content(/^\s*use_sudo:\sTrue$/) }
+    it { should contain_file(sudo_conf_file).with_content(/^dd-agent\sALL=.*NOPASSWD:\/usr\/bin\/ceph$/) }
+  end
+
 end

templates/agent-conf.d/ceph.yaml.erb

@@ -1,10 +1,14 @@
 init_config:
 
 instances:
+<% if @tags and ! @tags.empty? -%>
   - tags:
-    - name:ceph_cluster
+  <%- @tags.each do |tag| -%>
+    - <%= tag %>
+  <%- end -%>
+<% end -%>
 
-    ceph_cmd: /usr/bin/ceph
+    ceph_cmd: <%= @ceph_cmd %>
 
 # If your environment requires sudo, please add a line like:
 #          dd-agent ALL=(ALL) NOPASSWD:/usr/bin/ceph