Skip to content

Commit b32cb95

Browse files
committed
Merge branch 'main' of github.com:DataDog/puppet-datadog-agent into kfairise/remove-ruby-module
2 parents 57cdbc8 + c42d8ee commit b32cb95

58 files changed

Lines changed: 171 additions & 173 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.fixtures.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ fixtures:
22
repositories:
33
stdlib:
44
repo: "git://github.com/puppetlabs/puppetlabs-stdlib.git"
5-
ref: "4.24.0"
5+
ref: "4.25.0"
66
concat:
77
repo: "git://github.com/puppetlabs/puppetlabs-concat.git"
88
ref: "4.1.1"

environments/etc/Puppetfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ mod 'datadog_agent', :local => true
33
mod 'puppetlabs-apt', '2.4.0'
44
mod 'puppetlabs-concat', '4.0.0'
55
mod 'puppetlabs-puppetserver_gem', '1.0.0'
6-
mod 'puppetlabs-stdlib', '4.24.0'
6+
mod 'puppetlabs-stdlib', '4.25.0'
77
mod 'puppetlabs-powershell', '2.3.0'
88
mod 'puppetlabs-yumrepo_core', '1.0.3'
99
mod 'puppet-zypprepo', '3.1.0'

manifests/init.pp

Lines changed: 44 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -69,18 +69,13 @@
6969
# $log_to_syslog
7070
# Set value of 'log_to_syslog' variable. Default is true -> yes as in dd-agent.
7171
# Valid values here are: true or false.
72-
# $dogstatsd_port
73-
# Set value of the 'dogstatsd_port' variable. Defaultis 8125.
7472
# $report_fact_tags
7573
# Sets tags for report events sent to Datadog from specified facts
7674
# $report_trusted_fact_tags
7775
# Sets tags for report events sent to Datadog from specified trusted facts
7876
# $statsd_forward_host
7977
# Set the value of the statsd_forward_host varable. Used to forward all
8078
# statsd metrics to another host.
81-
# $statsd_forward_port
82-
# Set the value of the statsd_forward_port varable. Used to forward all
83-
# statsd metrics to another host.
8479
# $manage_repo
8580
# Deprecated. Only works for RPM. Install datadog-agent manually and then set
8681
# manage_install=false to achieve the same behaviour as setting this to false.
@@ -131,7 +126,7 @@
131126
# String. Default: empty
132127
# $dogstatsd_port
133128
# Specifies the port to be used by dogstatsd. Must have use_dogstatsd set
134-
# String. Default: empty
129+
# String. Default: 8125
135130
# $dogstatsd_target
136131
# Change the target to be used by dogstatsd. Must have use_dogstatsd set
137132
# set
@@ -146,8 +141,9 @@
146141
# Enables forwarding of statsd packetsto host. Must have use_dogstatsd set
147142
# String. Default: empty
148143
# $statsd_forward_port
149-
# Specifis port for $statsd_forward_host. Must have use_dogstatsd set
150-
# String. Default: empty
144+
# Specifies port for $statsd_forward_host. Must have use_dogstatsd set String.
145+
# Used to forward all statsd metrics to another host.
146+
# Default: empty
151147
# $device_blacklist_re
152148
# Specifies pattern for device blacklisting.
153149
# String. Default: empty
@@ -238,6 +234,11 @@
238234
# To use NPM features it is necessary to enable install through this flag, as well as
239235
# configuring NPM through the datadog::system_probe class.
240236
# Boolean. Default: false
237+
# $windows_ddagentuser_name
238+
# (Windows only) The name of Windows user to use, in the format `<domain>\<user>`.
239+
#
240+
# $windows_ddagentuser_password
241+
# (Windows only) The password used to register the service`.
241242
#
242243
# Sample Usage:
243244
#
@@ -283,30 +284,30 @@
283284
Boolean $manage_install = true,
284285
$hostname_extraction_regex = undef,
285286
Boolean $hostname_fqdn = false,
286-
$dogstatsd_port = 8125,
287+
Variant[Stdlib::Port, Pattern[/^\d*$/]] $dogstatsd_port = 8125,
287288
$dogstatsd_socket = '',
288289
Array $report_fact_tags = [],
289290
Array $report_trusted_fact_tags = [],
290291
String $statsd_forward_host = '',
291-
$statsd_forward_port = '',
292+
Variant[Stdlib::Port, Pattern[/^\d*$/]] $statsd_forward_port = '',
292293
String $statsd_histogram_percentiles = '0.95',
293294
Optional[String] $proxy_host = undef,
294295
Optional[Variant[Integer, Pattern[/^\d*$/]]] $proxy_port = undef,
295296
Optional[String] $proxy_user = undef,
296297
Optional[String] $proxy_password = undef,
297-
$graphite_listen_port = '',
298+
Variant[Stdlib::Port, Pattern[/^\d*$/]] $graphite_listen_port = '',
298299
String $extra_template = '',
299300
String $ganglia_host = '',
300301
$ganglia_port = 8651,
301302
Boolean $skip_ssl_validation = false,
302303
Boolean $skip_apt_key_trusting = false,
303304
Boolean $use_curl_http_client = false,
304305
String $recent_point_threshold = '',
305-
$listen_port = '',
306+
Variant[Stdlib::Port, Pattern[/^\d*$/]] $listen_port = '',
306307
Optional[String] $additional_checksd = undef,
307308
String $bind_host = '',
308309
Boolean $use_pup = false,
309-
$pup_port = '',
310+
Variant[Stdlib::Port, Pattern[/^\d*$/]] $pup_port = '',
310311
String $pup_interface = '',
311312
String $pup_url = '',
312313
Boolean $use_dogstatsd = true,
@@ -321,7 +322,7 @@
321322
String $dogstatsd_log_file = '',
322323
String $pup_log_file = '',
323324
String $syslog_host = '',
324-
$syslog_port = '',
325+
Variant[Stdlib::Port, Pattern[/^\d*$/]] $syslog_port = '',
325326
String $service_discovery_backend = '',
326327
String $sd_config_backend = '',
327328
String $sd_backend_host = '',
@@ -333,7 +334,6 @@
333334
Optional[Integer] $agent_major_version = undef,
334335
Optional[String] $conf_dir = undef,
335336
Boolean $conf_dir_purge = $datadog_agent::params::conf_dir_purge,
336-
$dd_user = $datadog_agent::params::dd_user,
337337
$dd_group = $datadog_agent::params::dd_group,
338338
$dd_groups = $datadog_agent::params::dd_groups,
339339
Boolean $apm_enabled = $datadog_agent::params::apm_default_enabled,
@@ -361,6 +361,8 @@
361361
Optional[String] $service_provider = undef,
362362
Optional[String] $agent_version = $datadog_agent::params::agent_version,
363363
Boolean $windows_npm_install = false,
364+
Optional[String] $windows_ddagentuser_name = undef,
365+
Optional[String] $windows_ddagentuser_password = undef,
364366
) inherits datadog_agent::params {
365367

366368
#In this regex, version '1:6.15.0~rc.1-1' would match as $1='1:', $2='6', $3='15', $4='0', $5='~rc.1', $6='1'
@@ -379,22 +381,11 @@
379381
fail("agent_major_version must be either 5, 6 or 7, not ${_agent_major_version}")
380382
}
381383

382-
# Allow ports to be passed as integers or strings.
383-
# lint:ignore:only_variable_string
384-
$_dogstatsd_port = "${dogstatsd_port}"
385-
$_statsd_forward_port = "${statsd_forward_port}"
386-
$_graphite_listen_port = "${graphite_listen_port}"
387-
$_listen_port = "${listen_port}"
388-
$_pup_port = "${pup_port}"
389-
$_syslog_port = "${syslog_port}"
390-
# lint:endignore
391-
392-
validate_legacy(String, 'validate_re', $_dogstatsd_port, '^\d*$')
393-
validate_legacy(String, 'validate_re', $_statsd_forward_port, '^\d*$')
394-
validate_legacy(String, 'validate_re', $_graphite_listen_port, '^\d*$')
395-
validate_legacy(String, 'validate_re', $_listen_port, '^\d*$')
396-
validate_legacy(String, 'validate_re', $_pup_port, '^\d*$')
397-
validate_legacy(String, 'validate_re', $_syslog_port, '^\d*$')
384+
if ($::operatingsystem == 'Windows' and $windows_ddagentuser_name != undef) {
385+
$dd_user = $windows_ddagentuser_name
386+
} else {
387+
$dd_user = $datadog_agent::params::dd_user
388+
}
398389

399390
if $conf_dir == undef {
400391
if $_agent_major_version == 5 {
@@ -461,15 +452,17 @@
461452
}
462453
'Windows' : {
463454
class { 'datadog_agent::windows' :
464-
agent_major_version => $_agent_major_version,
465-
agent_repo_uri => $agent_repo_uri,
466-
agent_version => $agent_version,
467-
msi_location => $win_msi_location,
468-
api_key => $api_key,
469-
hostname => $host,
470-
tags => $local_tags,
471-
ensure => $win_ensure,
472-
npm_install => $windows_npm_install,
455+
agent_major_version => $_agent_major_version,
456+
agent_repo_uri => $agent_repo_uri,
457+
agent_version => $agent_version,
458+
msi_location => $win_msi_location,
459+
api_key => $api_key,
460+
hostname => $host,
461+
tags => $local_tags,
462+
ensure => $win_ensure,
463+
npm_install => $windows_npm_install,
464+
ddagentuser_name => $windows_ddagentuser_name,
465+
ddagentuser_password => $windows_ddagentuser_password,
473466
}
474467
if ($win_ensure == absent) {
475468
return() #Config files will remain unchanged on uninstall
@@ -557,7 +550,7 @@
557550
require => File['/etc/dd-agent'],
558551
}
559552

560-
if ($dd_url == '') {
553+
if $dd_url.empty {
561554
$_dd_url = 'https://app.datadoghq.com'
562555
} else {
563556
$_dd_url = $dd_url
@@ -585,7 +578,7 @@
585578
order => '05',
586579
}
587580

588-
if ($extra_template != '') {
581+
unless $extra_template.empty {
589582
concat::fragment{ 'datadog extra_template footer':
590583
target => '/etc/dd-agent/datadog.conf',
591584
content => template($extra_template),
@@ -663,12 +656,12 @@
663656
},
664657
}
665658
}
666-
if $host != '' {
659+
if $host.empty {
660+
$host_config = {}
661+
} else {
667662
$host_config = {
668663
'hostname' => $host,
669664
}
670-
} else {
671-
$host_config = {}
672665
}
673666

674667
if $apm_analyzed_spans {
@@ -691,19 +684,19 @@
691684
$apm_obfuscation_config = {}
692685
}
693686

694-
if $statsd_forward_host != '' {
695-
if $_statsd_forward_port != '' {
687+
if $statsd_forward_host.empty {
688+
$statsd_forward_config = {}
689+
} else {
690+
if String($statsd_forward_port).empty {
696691
$statsd_forward_config = {
697692
'statsd_forward_host' => $statsd_forward_host,
698-
'statsd_forward_port' => $statsd_forward_port,
699693
}
700694
} else {
701695
$statsd_forward_config = {
702696
'statsd_forward_host' => $statsd_forward_host,
697+
'statsd_forward_port' => $statsd_forward_port,
703698
}
704699
}
705-
} else {
706-
$statsd_forward_config = {}
707700
}
708701

709702
if $additional_checksd {
@@ -761,6 +754,7 @@
761754

762755
if ($::operatingsystem == 'Windows') {
763756

757+
764758
file { 'C:/ProgramData/Datadog':
765759
ensure => directory
766760
}

manifests/integrations/activemq_xml.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363

6464
file { $dst_dir:
6565
ensure => directory,
66-
owner => $datadog_agent::params::dd_user,
66+
owner => $datadog_agent::dd_user,
6767
group => $datadog_agent::params::dd_group,
6868
mode => $datadog_agent::params::permissions_directory,
6969
require => Package[$datadog_agent::params::package_name],
@@ -92,7 +92,7 @@
9292

9393
file { $dst:
9494
ensure => file,
95-
owner => $datadog_agent::params::dd_user,
95+
owner => $datadog_agent::dd_user,
9696
group => $datadog_agent::params::dd_group,
9797
mode => $datadog_agent::params::permissions_protected_file,
9898
content => template('datadog_agent/agent-conf.d/activemq_xml.yaml.erb'),

manifests/integrations/apache.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
file { $dst_dir:
4646
ensure => directory,
47-
owner => $datadog_agent::params::dd_user,
47+
owner => $datadog_agent::dd_user,
4848
group => $datadog_agent::params::dd_group,
4949
mode => $datadog_agent::params::permissions_directory,
5050
require => Package[$datadog_agent::params::package_name],
@@ -57,7 +57,7 @@
5757

5858
file { $dst:
5959
ensure => file,
60-
owner => $datadog_agent::params::dd_user,
60+
owner => $datadog_agent::dd_user,
6161
group => $datadog_agent::params::dd_group,
6262
mode => $datadog_agent::params::permissions_protected_file,
6363
content => template('datadog_agent/agent-conf.d/apache.yaml.erb'),

manifests/integrations/cacti.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
file { $dst_dir:
3131
ensure => directory,
32-
owner => $datadog_agent::params::dd_user,
32+
owner => $datadog_agent::dd_user,
3333
group => $datadog_agent::params::dd_group,
3434
mode => $datadog_agent::params::permissions_directory,
3535
require => Package[$datadog_agent::params::package_name],
@@ -42,7 +42,7 @@
4242

4343
file { $dst:
4444
ensure => file,
45-
owner => $datadog_agent::params::dd_user,
45+
owner => $datadog_agent::dd_user,
4646
group => $datadog_agent::params::dd_group,
4747
mode => $datadog_agent::params::permissions_protected_file,
4848
content => template('datadog_agent/agent-conf.d/cacti.yaml.erb'),

manifests/integrations/cassandra.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
}
4848
file { $dst_dir:
4949
ensure => directory,
50-
owner => $datadog_agent::params::dd_user,
50+
owner => $datadog_agent::dd_user,
5151
group => $datadog_agent::params::dd_group,
5252
mode => $datadog_agent::params::permissions_directory,
5353
require => Package[$datadog_agent::params::package_name],
@@ -60,7 +60,7 @@
6060

6161
file { $dst:
6262
ensure => file,
63-
owner => $datadog_agent::params::dd_user,
63+
owner => $datadog_agent::dd_user,
6464
group => $datadog_agent::params::dd_group,
6565
mode => $datadog_agent::params::permissions_protected_file,
6666
content => template('datadog_agent/agent-conf.d/cassandra.yaml.erb'),

manifests/integrations/ceph.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
file { $dst_dir:
3434
ensure => directory,
35-
owner => $datadog_agent::params::dd_user,
35+
owner => $datadog_agent::dd_user,
3636
group => $datadog_agent::params::dd_group,
3737
mode => $datadog_agent::params::permissions_directory,
3838
require => Package[$datadog_agent::params::package_name],
@@ -45,7 +45,7 @@
4545

4646
file { $dst:
4747
ensure => file,
48-
owner => $datadog_agent::params::dd_user,
48+
owner => $datadog_agent::dd_user,
4949
group => $datadog_agent::params::dd_group,
5050
mode => $datadog_agent::params::permissions_protected_file,
5151
content => template('datadog_agent/agent-conf.d/ceph.yaml.erb'),

manifests/integrations/consul.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
file { $dst_dir:
4646
ensure => directory,
47-
owner => $datadog_agent::params::dd_user,
47+
owner => $datadog_agent::dd_user,
4848
group => $datadog_agent::params::dd_group,
4949
mode => $datadog_agent::params::permissions_directory,
5050
require => Package[$datadog_agent::params::package_name],
@@ -57,7 +57,7 @@
5757

5858
file { $dst:
5959
ensure => file,
60-
owner => $datadog_agent::params::dd_user,
60+
owner => $datadog_agent::dd_user,
6161
group => $datadog_agent::params::dd_group,
6262
mode => $datadog_agent::params::permissions_file,
6363
content => template('datadog_agent/agent-conf.d/consul.yaml.erb'),

manifests/integrations/directory.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797

9898
file { $dst_dir:
9999
ensure => directory,
100-
owner => $datadog_agent::params::dd_user,
100+
owner => $datadog_agent::dd_user,
101101
group => $datadog_agent::params::dd_group,
102102
mode => $datadog_agent::params::permissions_directory,
103103
require => Package[$datadog_agent::params::package_name],
@@ -110,7 +110,7 @@
110110

111111
file { $dst:
112112
ensure => file,
113-
owner => $datadog_agent::params::dd_user,
113+
owner => $datadog_agent::dd_user,
114114
group => $datadog_agent::params::dd_group,
115115
mode => $datadog_agent::params::permissions_protected_file,
116116
content => template('datadog_agent/agent-conf.d/directory.yaml.erb'),

0 commit comments

Comments
 (0)